From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: defcustom-c-stylevar rewrite: rfc #3 Date: Wed, 12 Dec 2007 11:07:15 +0100 Message-ID: <871w9sp6p8.fsf@ambire.localdomain> References: <87d4tkb4xy.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197454341 13702 80.91.229.12 (12 Dec 2007 10:12:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Dec 2007 10:12:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 12 11:12:31 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J2OZr-00076v-2J for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 11:12:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2OZY-00076B-Mu for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 05:12:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2OWX-0004bM-Os for emacs-devel@gnu.org; Wed, 12 Dec 2007 05:09:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2OWV-0004Wl-Ed for emacs-devel@gnu.org; Wed, 12 Dec 2007 05:09:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2OWU-0004WP-PS for emacs-devel@gnu.org; Wed, 12 Dec 2007 05:09:03 -0500 Original-Received: from ppp-157-32.21-151.libero.it ([151.21.32.157] helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J2OWR-0000FP-Qi; Wed, 12 Dec 2007 05:09:00 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1J2OUl-00023j-El; Wed, 12 Dec 2007 11:07:15 +0100 In-Reply-To: (Glenn Morris's message of "Thu, 06 Dec 2007 21:14:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85088 Archived-At: () Glenn Morris () Thu, 06 Dec 2007 21:14:49 -0500 Something is wrong: try to customize the variable c-indent-comment-alist after applying this change. Compare the choices on offer to those in Emacs-22. There are lots of "nils" now. thanks for reporting this. please find below a revision that evals the VAL argument (which is what i had originally, but someone convinced me to remove it). i see that customizing c-indent-comment-alist shows many choices now. thi ______________________________________________________________ (defmacro defcustom-c-stylevar (name val doc &rest args) "Define a style variable NAME with VAL and DOC. More precisely, convert the given `:type FOO', mined out of ARGS, to an aggregate `:type (radio STYLE (PREAMBLE FOO))', append some some boilerplate documentation to DOC, arrange for the fallback value of NAME to be VAL, and call `custom-declare-variable' to do the rest of the work. STYLE stands for the choice where the value is taken from some style setting. PREAMBLE is optionally prepended to FOO; that is, if FOO contains :tag or :value, the respective two-element list component is ignored." (declare (debug (symbolp form stringp &rest))) (let* ((expanded-doc (concat doc " This is a style variable. Apart from the valid values described above, it can be set to the symbol `set-from-style'. In that case, it takes its value from the style system (see `c-default-style' and `c-style-alist') when a CC Mode buffer is initialized. Otherwise, the value set here overrides the style system (there is a variable `c-old-style-variable-behavior' that changes this, though).")) (typ (eval (plist-get args :type))) (type (if (consp typ) typ (list typ))) (head (car type)) (tail (cdr type)) (newt (append (unless (plist-get tail :tag) '(:tag "Override style settings")) (unless (plist-get tail :value) `(:value ,(eval val))) tail)) (aggregate `'(radio (const :tag "Use style settings" set-from-style) ,(cons head newt)))) `(progn (c-set-stylevar-fallback ',name ,val) (custom-declare-variable ',name ''set-from-style ,expanded-doc ,@(plist-put args :type aggregate)))))