unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yoni Rabkin Katzenell <yoni-r@actcom.com>
To: emacs-devel@gnu.org
Subject: Re: Uninformative comment in files.el
Date: Wed, 12 Dec 2007 17:41:59 +0200	[thread overview]
Message-ID: <871w9rudh4.fsf@actcom.com> (raw)
In-Reply-To: <jwvlk80eyie.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 12 Dec 2007 10:20:16 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> After reading that thread (which I neglected to do beforehand, sorry) I
>> still think that revert-buffer should remove all overlays and the mark.
>
> I disagree.  Anything that's not a minor mode will suffer from similar
> problems and setting revert-buffer-function is not an option for them.
> Your change will cause problems for the other category of minor-mode
> like packages: those that need their overlays to survive a revert-buffer.

Maybe what confuses me is that it is called `revert-buffer' and not
something like `revert-to-file-contents'. I'd expect the former to
revert the buffer to a pristine state, but the latter to only change the
contents as they relate to the associated file.

I'll recapitulate what I wrote in a separate response: I'll wait until
it is clear what you guys want to do with `revert-buffer' (if anything),
then I'll see if I can help implement that. Currently I'm both unclear
as to the purpose of the function, and obviously ignorant of the
subtleties.

-- 
   "Cut your own wood and it will warm you twice"

  reply	other threads:[~2007-12-12 15:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 18:46 Uninformative comment in files.el Stefan Monnier
2007-12-11 20:55 ` Vinicius Jose Latorre
2007-12-11 22:05   ` martin rudalics
2007-12-12  2:22     ` Vinicius Jose Latorre
2007-12-12  6:31       ` Yoni Rabkin Katzenell
2007-12-12  9:17         ` martin rudalics
2007-12-12 14:22           ` Yoni Rabkin Katzenell
2007-12-12 12:28         ` Vinicius Jose Latorre
2007-12-12 15:20         ` Stefan Monnier
2007-12-12 15:41           ` Yoni Rabkin Katzenell [this message]
2007-12-13 16:51           ` Richard Stallman
2007-12-13 17:00             ` Stefan Monnier
2007-12-13 19:01               ` martin rudalics
2007-12-13 19:35                 ` David Kastrup
2007-12-14 20:49                   ` Richard Stallman
2007-12-14 20:49               ` Richard Stallman
2007-12-16  3:43                 ` Stephen J. Turnbull
2007-12-17  8:24                   ` Richard Stallman
     [not found]       ` <E1J2aRp-00010Y-QD@fencepost.gnu.org>
     [not found]         ` <476084A9.4010800@ig.com.br>
2007-12-14 10:10           ` Richard Stallman
2007-12-20 23:54             ` Stefan Monnier
2007-12-21 19:49               ` Richard Stallman
2007-12-23  0:57                 ` Stefan Monnier
2007-12-12 22:52   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871w9rudh4.fsf@actcom.com \
    --to=yoni-r@actcom.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).