From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: C-r and C-s in minibuffer should search completion Date: Sun, 06 Apr 2008 23:45:10 +0300 Organization: JURTA Message-ID: <871w5j2ca1.fsf@jurta.org> References: <87prtiik0l.fsf@jurta.org> <87iqz969fh.fsf@jurta.org> <87od9181m7.fsf@jurta.org> <87lk440z31.fsf@jurta.org> <87od8xccz6.fsf@jurta.org> <87hceouksk.fsf@jurta.org> <87y77zlqji.fsf@jurta.org> <873aq2czp4.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207516657 16808 80.91.229.12 (6 Apr 2008 21:17:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Apr 2008 21:17:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 06 23:18:00 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JicFU-0007ga-Az for ged-emacs-devel@m.gmane.org; Sun, 06 Apr 2008 23:18:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JicEr-0002rl-8F for ged-emacs-devel@m.gmane.org; Sun, 06 Apr 2008 17:17:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JicDX-0002Da-P5 for emacs-devel@gnu.org; Sun, 06 Apr 2008 17:15:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JicDW-0002Ce-3C for emacs-devel@gnu.org; Sun, 06 Apr 2008 17:15:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JicDV-0002Cb-SL for emacs-devel@gnu.org; Sun, 06 Apr 2008 17:15:57 -0400 Original-Received: from relay03.kiev.sovam.com ([62.64.120.201]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JicDV-0004bS-Gr for emacs-devel@gnu.org; Sun, 06 Apr 2008 17:15:57 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JicDT-000Oab-PZ; Mon, 07 Apr 2008 00:15:56 +0300 In-Reply-To: (Stefan Monnier's message of "Thu, 03 Apr 2008 21:18:47 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 88f972a75cd389d721acc69b695bb680 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2569 [Apr 04 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94507 Archived-At: >> Adding a new argument to `read-buffer' will cause the argument list >> mismatch between `read-buffer' and `read-buffer-function', and >> calling `read-buffer-function' with an additional argument will >> break existing code. > > Then lets fix the existing code. This means changing several places in Emacs and still breaking compatibility with external packages, and all this hassle just for fixing a minor problem. I think this fix is disproportional to the problem. OTOH, my latest patch implements exactly what is needed: using your suggestion to place code in the interactive spec of switch-buffer-*, it also sets a special function minibuffer-default-add-function that removes the current buffer from the list of defaults of switch-buffer-* commands. Thus, this is a very localized fix. I spent enough time trying hard to find a better solution, but I see no better. I propose to install this fix and move to more important things. -- Juri Linkov http://www.jurta.org/emacs/