From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: dbusbind.c patch, fixes possible segfault Date: Sun, 13 Apr 2008 18:43:13 +0200 Message-ID: <871w59d7tq.fsf@gmx.de> References: <874pa5ltgh.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208104882 12861 80.91.229.12 (13 Apr 2008 16:41:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Apr 2008 16:41:22 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 13 18:41:58 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jl5H9-00086s-He for ged-emacs-devel@m.gmane.org; Sun, 13 Apr 2008 18:41:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl5GV-0005Fh-Gf for ged-emacs-devel@m.gmane.org; Sun, 13 Apr 2008 12:41:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jl5GO-0005Bz-Nz for emacs-devel@gnu.org; Sun, 13 Apr 2008 12:41:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jl5GN-0005A8-8o for emacs-devel@gnu.org; Sun, 13 Apr 2008 12:41:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl5GM-0005A3-UW for emacs-devel@gnu.org; Sun, 13 Apr 2008 12:41:06 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Jl5GM-0000ur-Dr for emacs-devel@gnu.org; Sun, 13 Apr 2008 12:41:06 -0400 Original-Received: (qmail invoked by alias); 13 Apr 2008 16:41:04 -0000 Original-Received: from p57A2286F.dip0.t-ipconnect.de (EHLO arthur.local) [87.162.40.111] by mail.gmx.net (mp010) with SMTP; 13 Apr 2008 18:41:04 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+O7kU6//uOWleNiXVyrWzOwSropfNq1D2ECxIFJg kq23d1Z1tnA6ch In-Reply-To: <874pa5ltgh.fsf@localhorst.mine.nu> (David Hansen's message of "Sun, 13 Apr 2008 16:28:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95114 Archived-At: David Hansen writes: > This one is similar to the previous dbusbind.c patch. No need to copy > the string and if dbus_bus_get_unique_name () returns NULL strcpy will > segfault. Looks OK, I've committed it. Thanks a lot! Btw, I'm a little bit curious how you've managed it NOT to have a unique name? > David Best regards, Michael.