From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: recent checkin broke the Emacs build Date: Fri, 13 Feb 2009 08:25:48 +0100 Message-ID: <871vu2x0g3.fsf@thinkpad.tsdh.de> References: <36366a980902102137p3f495058hfb9bb9eb827edca@mail.gmail.com> <36366a980902112042i1632c9ecnfae66669cc2ad172@mail.gmail.com> <8763jgt5q4.fsf@turtle.gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1234510053 16059 80.91.229.12 (13 Feb 2009 07:27:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Feb 2009 07:27:33 +0000 (UTC) Cc: Eric Hanchrow , emacs-devel@gnu.org To: Sven Joachim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 13 08:28:48 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LXsTe-0004Zs-0N for ged-emacs-devel@m.gmane.org; Fri, 13 Feb 2009 08:28:46 +0100 Original-Received: from localhost ([127.0.0.1]:55225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXsSJ-000085-AE for ged-emacs-devel@m.gmane.org; Fri, 13 Feb 2009 02:27:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXsQr-00078T-Be for emacs-devel@gnu.org; Fri, 13 Feb 2009 02:25:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXsQq-00077e-9a for emacs-devel@gnu.org; Fri, 13 Feb 2009 02:25:52 -0500 Original-Received: from [199.232.76.173] (port=59395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXsQq-00077M-0Y for emacs-devel@gnu.org; Fri, 13 Feb 2009 02:25:52 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]:54826) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXsQp-0005Go-O1 for emacs-devel@gnu.org; Fri, 13 Feb 2009 02:25:51 -0500 Original-Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 630B0294627; Fri, 13 Feb 2009 02:25:51 -0500 (EST) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute2.internal (MEProxy); Fri, 13 Feb 2009 02:25:51 -0500 X-Sasl-enc: pYVG1X6faEX9G3YkiEo3o52W7W8bwL7m8vSVr63blFcs 1234509950 Original-Received: from thinkpad.tsdh.de (p54AF2094.dip0.t-ipconnect.de [84.175.32.148]) by mail.messagingengine.com (Postfix) with ESMTPA id EC50D22B5D; Fri, 13 Feb 2009 02:25:49 -0500 (EST) In-Reply-To: <8763jgt5q4.fsf@turtle.gmx.de> (Sven Joachim's message of "Thu, 12 Feb 2009 09:33:07 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) Mail-Copies-To: never Mail-Followup-To: Sven Joachim , Eric Hanchrow , emacs-devel@gnu.org X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109032 Archived-At: Sven Joachim writes: Hi Sven, > On 2009-02-12 05:42 +0100, Eric Hanchrow wrote: > >> In file included from /usr/local/src/emacs/lib-src/movemail.c:687: >> /usr/include/time.h: At top level: >> /usr/include/time.h:187: error: conflicting types for 'time' >> /usr/local/src/emacs/lib-src/movemail.c:362: error: previous implicit >> declaration of 'time' was here > > Here is a patch for this: > > --- movemail.c.~1.99.~ 2009-02-12 09:07:07.000000000 +0100 > +++ movemail.c 2009-02-12 09:25:41.000000000 +0100 > @@ -60,6 +60,7 @@ > #include > #include > #include > +#include > > #include > #ifdef HAVE_UNISTD_H > @@ -375,7 +376,7 @@ > int lockcount = 0; > int status = 0; > #if defined (MAIL_USE_MAILLOCK) && defined (HAVE_TOUCHLOCK) > - long touched_lock, now; > + time_t touched_lock, now; > #endif > > setuid (getuid ()); > @@ -684,7 +685,6 @@ > #endif > #include > #include > -#include > > #define NOTOK (-1) > #define OK 0 > > Suggested Changelog entry: > > 2009-02-12 Sven Joachim > > * movemail.c (main): Include time.h unconditionally. I suffered from the error before and your patch works fine for me. Is there any reason not to check it in? Bye, Tassilo