unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 3361@emacsbugs.donarmstrong.com, duanpanda@gmail.com,
	emacs-devel@gnu.org
Subject: Re: 23.0.92; View-scroll-page-forward/backward does wrong in text mode after text-scale-increase/decrease
Date: Sat, 11 Jul 2009 23:39:43 +0300	[thread overview]
Message-ID: <871von6jjk.fsf@mail.jurta.org> (raw)
In-Reply-To: <87d49v53ba.fsf@cyd.mit.edu> (Chong Yidong's message of "Tue, 26 May 2009 10:47:21 -0400")

> View-mode, written in the dawn of time, assumes that all lines have the
> default height.  The following patch changes it so that
> scroll-up/scroll-down are passed nil arguments where possible; then
> Emacs will automatically determine how to scroll by one page, taking
> variable-height lines and text-scaling into account.
>
> It's not good to make this kind of change at this stage in the release,
> but this bug would be pretty annoying if you happen to come across it,
> and that's much more likely now we've introduced the text-scaling
> commands.  Could someone on emacs-devel help review the patch?

I noticed that this patch causes a regression: typing RET used to put
point to the last line at the end of the window, but now typing RET keeps
point on the same line.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  parent reply	other threads:[~2009-07-11 20:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 14:47 23.0.92; View-scroll-page-forward/backward does wrong in text mode after text-scale-increase/decrease Chong Yidong
2009-05-26 17:19 ` Stefan Monnier
2009-07-11 20:39 ` Juri Linkov [this message]
2009-07-12 16:44   ` Chong Yidong
2009-07-12 21:02     ` Juri Linkov
2009-07-13  0:08 ` Miles Bader
2009-07-13 20:07   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871von6jjk.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=3361@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=duanpanda@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).