From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stephen J. Turnbull" Newsgroups: gmane.emacs.devel Subject: Re: save-frame-excursion? Date: Mon, 27 Jul 2009 13:50:09 +0900 Message-ID: <871vo2d91a.fsf@uwakimon.sk.tsukuba.ac.jp> References: <87ocrb8fy0.fsf@bzg.ath.cx> <4A691B47.1050102@sift.info> <4A692A6A.4080601@sift.info> <871vo5c7lj.fsf@bzg.ath.cx> <87y6qcbeg6.fsf@bzg.ath.cx> <87skgilrkr.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1248670482 31510 80.91.229.12 (27 Jul 2009 04:54:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jul 2009 04:54:42 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 27 06:54:33 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MVIEK-0000Yw-RP for ged-emacs-devel@m.gmane.org; Mon, 27 Jul 2009 06:54:33 +0200 Original-Received: from localhost ([127.0.0.1]:43418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVIEK-0005Lf-2v for ged-emacs-devel@m.gmane.org; Mon, 27 Jul 2009 00:54:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVIDk-0004uc-2h for emacs-devel@gnu.org; Mon, 27 Jul 2009 00:53:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVIDf-0004rk-I9 for emacs-devel@gnu.org; Mon, 27 Jul 2009 00:53:55 -0400 Original-Received: from [199.232.76.173] (port=47853 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVIDf-0004rd-Dg for emacs-devel@gnu.org; Mon, 27 Jul 2009 00:53:51 -0400 Original-Received: from mtps01.sk.tsukuba.ac.jp ([130.158.97.223]:60075) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVIDe-0001qh-Ov for emacs-devel@gnu.org; Mon, 27 Jul 2009 00:53:51 -0400 Original-Received: from uwakimon.sk.tsukuba.ac.jp (uwakimon.sk.tsukuba.ac.jp [130.158.99.156]) by mtps01.sk.tsukuba.ac.jp (Postfix) with ESMTP id 9D6FA1537B5; Mon, 27 Jul 2009 13:53:48 +0900 (JST) Original-Received: by uwakimon.sk.tsukuba.ac.jp (Postfix, from userid 1000) id 294791A3002; Mon, 27 Jul 2009 13:50:10 +0900 (JST) In-Reply-To: <87skgilrkr.fsf@bzg.ath.cx> X-Mailer: VM 8.0.12-devo-585 under 21.5 (beta29) "garbanzo" 5bbff3553494 XEmacs Lucid (x86_64-unknown-linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113203 Archived-At: Bastien writes: > Stefan Monnier writes: > > > So the really better fix would be to make sure make-frame doesn't change > > the focus (especially since the above note is not quite correct: even > > for click-to-focus WMs, the new frames may get selected just by virtue > > of being new, which is most likely what you're seeing). > > This patch makes sure that `make-frame' gives the focus back to the > previously selected frame. I think the hook should be run *after* returning focus to the frame, in case of a hook function that wants to do something with the focus. I have no opinion on whether this patch is a good way to address the issue, however. w