From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Cygwin patches Date: Fri, 20 Nov 2009 16:50:39 -0500 Message-ID: <871vjs7tn4.fsf@stupidchicken.com> References: <4B06F562.8060504@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258753866 12543 80.91.229.12 (20 Nov 2009 21:51:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Nov 2009 21:51:06 +0000 (UTC) Cc: Emacs To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 20 22:50:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBbNY-0001OQ-5g for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2009 22:50:56 +0100 Original-Received: from localhost ([127.0.0.1]:47143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBbNX-000181-4W for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2009 16:50:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBbNR-00017l-TY for emacs-devel@gnu.org; Fri, 20 Nov 2009 16:50:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBbNN-00014m-DT for emacs-devel@gnu.org; Fri, 20 Nov 2009 16:50:49 -0500 Original-Received: from [199.232.76.173] (port=50707 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBbNN-00014g-B4 for emacs-devel@gnu.org; Fri, 20 Nov 2009 16:50:45 -0500 Original-Received: from pantheon-po23.its.yale.edu ([130.132.50.117]:56418) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBbNN-0007To-1z for emacs-devel@gnu.org; Fri, 20 Nov 2009 16:50:45 -0500 Original-Received: from furry (dhcp-18-111-38-36.dyn.mit.edu [18.111.38.36]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id nAKLodhH003231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 20 Nov 2009 16:50:39 -0500 Original-Received: by furry (Postfix, from userid 1000) id AF21DC071; Fri, 20 Nov 2009 16:50:39 -0500 (EST) In-Reply-To: <4B06F562.8060504@cornell.edu> (Ken Brown's message of "Fri, 20 Nov 2009 15:00:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117382 Archived-At: Ken Brown writes: > Now that you're preparing for emacs 23.2, could you please apply the > cygwin patches that I submitted last June? Thanks, I've checked in your changes, except for the following: > --- origsrc/lisp/net/browse-url.el 2009-11-20 11:34:25.000000000 -0500 > +++ src/lisp/net/browse-url.el 2009-11-20 11:35:28.000000000 -0500 > @@ -693,7 +693,9 @@ > (cond ((not (buffer-modified-p))) > (browse-url-save-file (save-buffer)) > (t (message "%s modified since last save" file)))))) > - (browse-url (browse-url-file-url file)) > + (if (eq system-type 'cygwin) > + (shell-command (concat "cygstart " (shell-quote-argument file))) > + (browse-url (browse-url-file-url file))) > (run-hooks 'browse-url-of-file-hook)) I still don't understand why cygwin needs special handling when, e.g., the other Windows ports don't. Could you explain?