tiny font-lock change to lisp/bs.el

tiny font-lock change to lisp/bs.el

[Yoni Rabkin]

Hello (I am using GNU Emacs 23.1.96.2),

The font-lock regexp on line 198 of bs.el reads:

    '("^..\\(.*Dired by .*\\)$" 1 font-lock-function-name-face)

But if you make the following modification (as I did in my .emacs):

    (setq dired-listing-switches "-lphaX")

Then the font-lock regexp no longer matches since the word "by" is
replaced by the value of `dired-listing-switches'.

A fix would be to remove the word "by" from the font-lock regexp:

    '("^..\\(.*Dired .*\\)$" 1 font-lock-function-name-face)

-- 
   "Cut your own wood and it will warm you twice"

Re: tiny font-lock change to lisp/bs.el

[Yoni Rabkin]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Yoni Rabkin <yoni@rabkins.net> writes:

> Hello (I am using GNU Emacs 23.1.96.2),
>
> The font-lock regexp on line 198 of bs.el reads:
>
>     '("^..\\(.*Dired by .*\\)$" 1 font-lock-function-name-face)
>
> But if you make the following modification (as I did in my .emacs):
>
>     (setq dired-listing-switches "-lphaX")
>
> Then the font-lock regexp no longer matches since the word "by" is
> replaced by the value of `dired-listing-switches'.
>
> A fix would be to remove the word "by" from the font-lock regexp:
>
>     '("^..\\(.*Dired .*\\)$" 1 font-lock-function-name-face)

To help this along, here is a bzr patch which does this:


[-- Attachment #2: patch to bs.el --]
[-- Type: text/plain, Size: 2182 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: yoni@rabkins.net-20100616212548-yj51i6b8qfs9s46l
# target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk
# testament_sha1: 83a81a6a2fa28bd7d015a1d3ae8c52efc66ba0f2
# timestamp: 2010-06-17 00:26:03 +0300
# source_branch: http://bzr.savannah.gnu.org/r/emacs/trunk
# base_revision_id: monnier@iro.umontreal.ca-20100616200841-\
#   2tn8nppsq7ej3xlv
# 
# Begin patch
=== modified file 'lisp/bs.el'
--- lisp/bs.el	2010-05-25 02:11:08 +0000
+++ lisp/bs.el	2010-06-16 21:25:48 +0000
@@ -195,7 +195,7 @@
 	     'font-lock-constant-face
 	   'font-lock-comment-face))
    ;; Dired-Buffers
-   '("^..\\(.*Dired by .*\\)$" 1 font-lock-function-name-face)
+   '("^..\\(.*Dired .*\\)$" 1 font-lock-function-name-face)
    ;; the star for modified buffers
    '("^.\\(\\*\\) +[^\\*]"     1 font-lock-comment-face))
   "Default font lock expressions for Buffer Selection Menu.")

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfyi+RwAAXzfgAAQVPP/91YC
ECW////wUANFkenCtrtbeEoRTNJiKeYmmmmUepP0psFPKeg0EBJJNGIMSZNInkm1BoPSDQ0MgElN
AVPU9TZQ2oNqaepo3qgAA0AIVGBMBNGAATJgAIwASU1Ghqnmo9RN6o9R+qAeoA0AMgM+sh2p6lVV
CUx1SgSyK0GZyzEN+bfWoq9uid3xxWs6cVyx875Glh2/r3+03dYlCW2izU9qMRr2Esrv5tord5Hy
XmngHIXUrZb+Nqbx964zS0r4bPzzDySO4IWY30eLHdZwjWLbcIbEjWCxLnOQSHKL2VTS6K9zVF86
5syVFzzEVpXOVa+1RUIwFKyl5bRQWS8DVZK69Bp0J8sNYJyoTJ7WV18dZlwt9VVCepWJZdUo5CxY
owdWCiz7laLcSNtdx65n6W7JXripWK+x+jaJ7FhDtFlRLfWQ8bV458ZivvoWitjPl6AhuzvoQPJc
0+NZG1BnEYmYm08ORpaqwcUFdhHEYU9Q7QPznBt06W9l9aLM3plMw1gkwOalDka33YRsi7moCuVZ
Yugs9n5kLGMSbjLiJ8Z3hdhXDJrn1sFCxNBrSIRwU5HhurkXOUrd0i8QuRI8qiqvp1mepdxL8k0U
uZgs4PMAYKy8/3vQiO35crw93A1U5O7dBD6THZtorwEnJAHP2q32lwbrCXHxexg79FngGc0fjrA1
2P4DaXwTRt1ReZEmRFp88iRBUTWluTNOnHhfNG6a3Zb9uxlxkbb5K2EQ7phqYjikFzIyWU2gcOtd
qhK5u38uLayL0yppp1hmu2O1D0SAZY0fpKKRa0OVNh0wgWIpnJDvhz0qGXkJ1+SK+LSYhZBQfMwF
Ulvjr/xOYH0NCYjkjDrcl+NKW1iy8zzDmHtwtdqvEWyk3Dv2BkuhBhisGYIBBkUT362lr4SkP5Mu
i03rx274sG4FLKiRFZ04tlKcgjf2JPeBPIGB/cv5MlOA4HAzky51CK3Duu1Hf/uSWoSGCBoDqPXy
ep8OMNuDMmIz4LFF6ZTWAuHfwSySsBtLXBgNdRG5i8py65q4IVyseF4SS7RTFdptzFHX4A6xRqir
SxEmFinOdsYNKppDPheca9FgGIFzKnYs9PSDQ71RRWgDAmjaJAAgKQDeHwOysyyoG9C7kinChIfl
F8jg

[-- Attachment #3: Type: text/plain, Size: 55 bytes --]


-- 
   "Cut your own wood and it will warm you twice"

Re: tiny font-lock change to lisp/bs.el

[Yoni Rabkin]

Another week has passed, so I'm nudging the list about this.

-- 
   "Cut your own wood and it will warm you twice"

Re: tiny font-lock change to lisp/bs.el

[Glenn Morris]

Yoni Rabkin wrote:

> Another week has passed, so I'm nudging the list about this.

It is better to send bug reports to the bug list.
Anyway, thanks, patch applied.