From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: tool-bars - broken again Date: Sat, 03 Jul 2010 18:27:53 -0400 Message-ID: <871vbk6w0m.fsf@stupidchicken.com> References: <17A106BDF5AA40A9B41416AE7E8F13CB@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278196086 3356 80.91.229.12 (3 Jul 2010 22:28:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 3 Jul 2010 22:28:06 +0000 (UTC) Cc: 'Emacs-Devel devel' To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 04 00:28:05 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVBBs-0005ha-Fj for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 00:28:04 +0200 Original-Received: from localhost ([127.0.0.1]:42490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVBBr-0000am-Kb for ged-emacs-devel@m.gmane.org; Sat, 03 Jul 2010 18:28:03 -0400 Original-Received: from [140.186.70.92] (port=35425 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVBBk-0000aP-Lh for emacs-devel@gnu.org; Sat, 03 Jul 2010 18:27:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVBBj-0000H0-66 for emacs-devel@gnu.org; Sat, 03 Jul 2010 18:27:56 -0400 Original-Received: from pantheon-po18.its.yale.edu ([130.132.50.74]:39486) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVBBj-0000Gr-1r for emacs-devel@gnu.org; Sat, 03 Jul 2010 18:27:55 -0400 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po18.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o63MRrRZ032115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 3 Jul 2010 18:27:54 -0400 Original-Received: by furry (Postfix, from userid 1000) id 7F21DC011; Sat, 3 Jul 2010 18:27:53 -0400 (EDT) In-Reply-To: <17A106BDF5AA40A9B41416AE7E8F13CB@us.oracle.com> (Drew Adams's message of "Sat, 3 Jul 2010 12:23:34 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126739 Archived-At: "Drew Adams" writes: > I must say, and I am trying to be polite, that I am really getting > tired of the fiddling with the tool bars that has been going on for > years now. I try to have code that works across versions. You just > won't leave it alone, it seems. No, we can't maintain cruft indefinitely. The complicated interaction between default-frame-alist and tool/menu bar mode needed simplifying. The default value of `default-frame-alist' is now nil, unless you explicitly set the value to something else. It is a properly-behaved defcustom (and so is `initial-frame-alist'); Emacs does not muck with the value when starting up, nor when you run the `*-bar-mode' commands. Conceptually, adding any element to `default-frame-alist' is like implicitly supplying an argument to `make-frame'. (Any actual argument you supply to `make-frame' takes precedence over `default-frame-alist'.) If no `tool-bar-lines' or `menu-bar-lines' parameter is supplied in the `make-frame' arguments or `default-frame-alist', Emacs sets the value from the value of `menu-bar-mode' and `tool-bar-mode'. > In my startup code, I set `default-frame-alist' and I also turn off > `tool-bar-mode'. Prior to the 6/28 build, the value of > `tool-bar-lines' in `default-frame-alist' was correctly set to 0 when > my code turned off `tool-bar-mode'; now it is not. You are likely setting a non-zero `tool-bar-lines' in `default-frame-alist'. I don't know why you would want to do this, if your intention is to disable the tool bar. As far as I can see, there is no bug here.