From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bug: epg send unencrypted data in trash Date: Sat, 12 Feb 2011 08:08:22 +0100 Message-ID: <871v3dspax.fsf@gmail.com> References: <87oc6jav1s.fsf@gmail.com> <87k4h6sahe.fsf@gmail.com> <87sjvuxs80.fsf@lifelogs.com> <87aai2s2nu.fsf@gmail.com> <87oc6iw75t.fsf@lifelogs.com> <87mxm285jp.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297494534 1986 80.91.229.12 (12 Feb 2011 07:08:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Feb 2011 07:08:54 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 12 08:08:50 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Po9b7-0007yG-Mk for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 08:08:49 +0100 Original-Received: from localhost ([127.0.0.1]:40599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po9b6-0003m8-SL for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 02:08:48 -0500 Original-Received: from [140.186.70.92] (port=42123 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po9b0-0003lz-J8 for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:08:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Po9ay-0000Vt-4h for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:08:41 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:58002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Po9ax-0000VN-Tx for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:08:40 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Po9au-0007wu-TR for emacs-devel@gnu.org; Sat, 12 Feb 2011 08:08:36 +0100 Original-Received: from 131.78.88-79.rev.gaoland.net ([79.88.78.131]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 12 Feb 2011 08:08:36 +0100 Original-Received: from thierry.volpiatto by 131.78.88-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 12 Feb 2011 08:08:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 131.78.88-79.rev.gaoland.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.93 (gnu/linux) Cancel-Lock: sha1:ZRKG3iH0Wb1p4QZtca5hAdo3s0I= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135931 Archived-At: Chong Yidong writes: > Ted Zlatanov writes: > >> On Fri, 11 Feb 2011 22:05:09 +0100 Thierry Volpiatto >> wrote: >> >> TV> Ted Zlatanov writes: >>>> According to the docs for `delete-file' it shouldn't matter what >>>> `delete-by-moving-to-trash' says because this is called >>>> non-interactively (TRASH is nil when delete-file is called >>>> non-interactively). Or is this funcall interactive somehow? >> TV> I don't know, but actually without delete-by-moving-to-trash let-bound >> TV> to nil, non--encrypted data goes to trash. >> >> I think this is because in the C source (fileio.c) TRASH is set to >> "(null current-prefix-arg)" which is not equivalent to >> `called-interactively-p' AFAIK. IOW I think your fix is masking the >> underlying problem. But I don't know the C source so well so I could be >> misunderstanding things. Perhaps Chong Yidong, who created revision >> 100462 and introduced the TRASH parameter, can check it. > > I think TV is using the emacs-23 branch, Yes. > where the TRASH parameter is > not present. I've changed EPA and EPG to bind delete-by-moving-to-trash > to nil there. No fix is necessary for the trunk, IIUC. > > -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997