From: David Engster <deng@randomsample.de>
To: Darren Hoo <darren.hoo@gmail.com>
Cc: "Eric M. Ludlam" <eric@siege-engine.com>, emacs-devel@gnu.org
Subject: Re: cedet-bzr build failure (was : Lexical binding)
Date: Sat, 02 Apr 2011 14:40:31 +0200 [thread overview]
Message-ID: <871v1kygg0.fsf@engster.org> (raw)
In-Reply-To: <87wrjd38xm.fsf@gmail.com> (Darren Hoo's message of "Sat, 02 Apr 2011 06:26:13 +0800")
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Darren Hoo writes:
> David Engster <deng@randomsample.de> writes:
>
>>> fail to build cedet-bzr after this merge
>>>
>>> Debugger entered--Lisp error:
>>> (wrong-type-argument listp "Forgot to expand macro eieio-object-p")
>>
>> Inside the cedet-bzr directory, try 'make clean-all' and compile again.
>>
> hmm, so there are changes in eieio.el in this merge, after I steal the
> changes and applied to cedet-bzr, eieio.el now builds successfully,
>
> But then I got another error:
>
> In toplevel form:
> semantic-grammar-wy.el:169:12:Error: Wrong type argument: listp, "Forgot
> to expand macro backquote-list*"
Yes, you're right. There was also a change to wisent-comp.el
(revno. 100595.1.31; you'll have to use "bzr log -n0" to see it).
I attached the patch with the changes for eieio.el and wisent-comp.el to
this mail. Eric, do you see a problem with committing those? I also
tested compilation with Emacs versions 23 and 22, and it seems to work
fine.
-David
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cedet-lexbind.patch --]
[-- Type: text/x-patch, Size: 1664 bytes --]
=== modified file 'eieio/eieio.el'
--- eieio/eieio.el 2011-01-27 20:42:06 +0000
+++ eieio/eieio.el 2011-04-02 12:29:01 +0000
@@ -1207,7 +1207,7 @@
(let ((byte-compile-free-references nil)
(byte-compile-warnings nil)
)
- (byte-compile-lambda
+ (byte-compile
`(lambda (&rest local-args)
,doc-string
;; This is a cool cheat. Usually we need to look up in the
=== modified file 'semantic/wisent/wisent-comp.el'
--- semantic/wisent/wisent-comp.el 2010-04-09 02:08:59 +0000
+++ semantic/wisent/wisent-comp.el 2011-04-02 12:32:40 +0000
@@ -3500,9 +3500,19 @@
;; automaton internal data structure. Then, because the internal
;; data structure contains an obarray, convert it to a lisp form so
;; it can be byte-compiled.
- (byte-compile-form (wisent-automaton-lisp-form (eval form))))
+ (byte-compile-form
+ ;; FIXME: we macroexpand here since `byte-compile-form' expects
+ ;; macroexpanded code, but that's just a workaround: for lexical-binding
+ ;; the lisp form should have to pass through closure-conversion and
+ ;; `wisent-byte-compile-grammar' is called much too late for that.
+ ;; Why isn't this `wisent-automaton-lisp-form' performed at
+ ;; macroexpansion time? --Stef
+ (macroexpand-all
+ (wisent-automaton-lisp-form (eval form)))))
-;;;###autoload
+;; FIXME: We shouldn't use a `byte-compile' handler. Maybe using a hash-table
+;; instead of an obarray would work around the problem that obarrays
+;; aren't printable. Then (put 'wisent-compile-grammar 'side-effect-free t).
(put 'wisent-compile-grammar 'byte-compile 'wisent-byte-compile-grammar)
(defun wisent-automaton-lisp-form (automaton)
next prev parent reply other threads:[~2011-04-02 12:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 17:32 Lexical binding Stefan Monnier
2011-04-01 19:12 ` David De La Harpe Golden
2011-04-01 19:46 ` Eli Zaretskii
2011-04-04 16:05 ` Stefan Monnier
2011-04-01 20:04 ` Daniel Colascione
2011-04-01 20:39 ` cedet-bzr build failure (was : Lexical binding) Darren Hoo
2011-04-01 21:21 ` David Engster
2011-04-01 22:26 ` Darren Hoo
2011-04-02 12:40 ` David Engster [this message]
2011-04-02 13:42 ` Eric M. Ludlam
2011-04-02 18:22 ` cedet-bzr build failure David Engster
2011-04-02 18:29 ` cedet-bzr build failure (was : Lexical binding) Darren Hoo
2011-04-01 20:42 ` Lexical binding Eli Zaretskii
2011-04-01 22:13 ` Juanma Barranquero
2011-04-02 2:33 ` Juanma Barranquero
2011-04-02 3:36 ` Juanma Barranquero
2011-04-02 18:38 ` Stefan Monnier
2011-04-04 16:04 ` Juanma Barranquero
2011-04-04 21:44 ` Stefan Monnier
2011-04-04 21:56 ` Juanma Barranquero
2011-04-04 22:03 ` David Kastrup
2011-04-04 22:34 ` Stefan Monnier
2011-04-02 18:38 ` Stefan Monnier
2011-04-02 18:50 ` Juanma Barranquero
2011-04-02 18:57 ` Juanma Barranquero
2011-04-03 12:05 ` Christian Ohler
2011-04-03 12:26 ` Juanma Barranquero
2011-04-03 23:32 ` Christian Ohler
2011-04-04 0:12 ` Juanma Barranquero
2011-04-04 16:22 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871v1kygg0.fsf@engster.org \
--to=deng@randomsample.de \
--cc=darren.hoo@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=eric@siege-engine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).