From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r108099: Silence byte-compiler warnings. Date: Wed, 02 May 2012 19:53:19 +0200 Message-ID: <871un2h3lc.fsf@gmx.de> References: <877gwuhgwx.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1335981218 8932 80.91.229.3 (2 May 2012 17:53:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 May 2012 17:53:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 02 19:53:37 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SPdk7-0004WB-6n for ged-emacs-devel@m.gmane.org; Wed, 02 May 2012 19:53:35 +0200 Original-Received: from localhost ([::1]:42153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPdk6-0003Wh-MK for ged-emacs-devel@m.gmane.org; Wed, 02 May 2012 13:53:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPdk1-0003WO-DW for emacs-devel@gnu.org; Wed, 02 May 2012 13:53:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPdjz-00031z-Ew for emacs-devel@gnu.org; Wed, 02 May 2012 13:53:28 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:40639) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1SPdjz-00031p-5W for emacs-devel@gnu.org; Wed, 02 May 2012 13:53:27 -0400 Original-Received: (qmail invoked by alias); 02 May 2012 17:53:21 -0000 Original-Received: from p57BB94F1.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.148.241] by mail.gmx.net (mp039) with SMTP; 02 May 2012 19:53:21 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+T2IsmZA6T8OjjrFbM46D1EMu+pBx/PliMRbJgbe N/MBEg0NHRagOT In-Reply-To: (Juanma Barranquero's message of "Wed, 2 May 2012 18:29:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150224 Archived-At: Juanma Barranquero writes: > On Wed, May 2, 2012 at 3:05 PM, Michael Albinus = wrote: > >> Just for curiosity: why that? dbus-debug is declared in dbus.el > > It's declared, but not defined: > > ;; Declare used subroutines and variables. > (declare-function dbus-message-internal "dbusbind.c") > [...] > (defvar dbus-debug) > (defvar dbus-registered-objects-table) I see. Thanks for the explanation. > An alternative fix would be to define it properly > > (defvar dbus-debug nil "...") > > which would clearly be the right thing if dbus-debug were part of > dbus.el's API. This is a corner case, because it is not advertised as > such, just used in a macroexpansion. `dbus-debug' is declared & defined un dbusbind.c, where it belongs to. Your proposal would work, but it would be another dirty declaration just in order to make the byte compiler silent. The real solution would be to exclude notification.el (and other packages) from byte compilation, if Emacs hasn't been compiled with D-Bus support. Unfortunately, I don't know how to say this. ;; Local Variables: ;; no-byte-compile: (null (featurep 'dbusbind)) ;; End:=20 does not work, because the value for `no-byte-compile' is not evaluated. ;; Local Variables: ;; eval: (setq no-byte-compile (null (featurep 'dbusbind))) ;; End:=20 doesn't work either. > =C2=A0 =C2=A0 Juanma Best regards, Michael.