From: Michael Albinus <michael.albinus@gmx.de>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r108099: Silence byte-compiler warnings.
Date: Wed, 02 May 2012 19:53:19 +0200 [thread overview]
Message-ID: <871un2h3lc.fsf@gmx.de> (raw)
In-Reply-To: <CAAeL0STBQ2gMXsvAfzP7U1MEA9DFQ_gXjRqu8zrKjSnh3+_+Ow@mail.gmail.com> (Juanma Barranquero's message of "Wed, 2 May 2012 18:29:46 +0200")
Juanma Barranquero <lekktu@gmail.com> writes:
> On Wed, May 2, 2012 at 3:05 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
>
>> Just for curiosity: why that? dbus-debug is declared in dbus.el
>
> It's declared, but not defined:
>
> ;; Declare used subroutines and variables.
> (declare-function dbus-message-internal "dbusbind.c")
> [...]
> (defvar dbus-debug)
> (defvar dbus-registered-objects-table)
I see. Thanks for the explanation.
> An alternative fix would be to define it properly
>
> (defvar dbus-debug nil "...")
>
> which would clearly be the right thing if dbus-debug were part of
> dbus.el's API. This is a corner case, because it is not advertised as
> such, just used in a macroexpansion.
`dbus-debug' is declared & defined un dbusbind.c, where it belongs
to. Your proposal would work, but it would be another dirty declaration
just in order to make the byte compiler silent.
The real solution would be to exclude notification.el (and other
packages) from byte compilation, if Emacs hasn't been compiled with
D-Bus support. Unfortunately, I don't know how to say this.
;; Local Variables:
;; no-byte-compile: (null (featurep 'dbusbind))
;; End:
does not work, because the value for `no-byte-compile' is not evaluated.
;; Local Variables:
;; eval: (setq no-byte-compile (null (featurep 'dbusbind)))
;; End:
doesn't work either.
> Juanma
Best regards, Michael.
next prev parent reply other threads:[~2012-05-02 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SPYUf-00015v-FZ@vcs.savannah.gnu.org>
2012-05-02 13:05 ` /srv/bzr/emacs/trunk r108099: Silence byte-compiler warnings Michael Albinus
2012-05-02 16:19 ` Juanma Barranquero
2012-05-02 16:29 ` Juanma Barranquero
2012-05-02 17:53 ` Michael Albinus [this message]
2012-05-02 19:43 ` Juanma Barranquero
2012-05-02 20:38 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871un2h3lc.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).