unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Kalle Olavi Niemitalo <kon@iki.fi>
Cc: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>,
	"Thien-Thi Nguyen" <ttn@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: [PATCH] Add support for C++ headers to `ffap'.
Date: Fri, 20 Sep 2013 10:47:21 +0200	[thread overview]
Message-ID: <871u4jdgme.fsf@igel.home> (raw)
In-Reply-To: <87zjr859jn.fsf@Niukka.kon.iki.fi> (Kalle Olavi Niemitalo's message of "Fri, 20 Sep 2013 08:47:24 +0300")

Kalle Olavi Niemitalo <kon@iki.fi> writes:

> Thien-Thi Nguyen <ttn@gnu.org> writes:
>
>> () Rüdiger Sonderfeld <ruediger@c-plusplus.de>
>> () Thu, 19 Sep 2013 23:51 +0200
>>
>>    + (when (= 0 (ignore-errors ...)))
>>
>> You can use ‘zerop’ here.
>
> If ignore-errors handles an error, it returns nil.  Don't both
> (= 0 nil) and (zerop nil) signal a wrong-type-argument error?
> I.e. should this instead be (ignore-errors (zerop ...))?

call-process can return a non-number as well.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



  reply	other threads:[~2013-09-20  8:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 21:51 [PATCH] Add support for C++ headers to `ffap' Rüdiger Sonderfeld
2013-09-20  5:26 ` Thien-Thi Nguyen
2013-09-20  5:47   ` Kalle Olavi Niemitalo
2013-09-20  8:47     ` Andreas Schwab [this message]
2013-09-20  8:36   ` Rüdiger Sonderfeld
2013-10-19  2:36     ` Glenn Morris
2013-09-20 10:10 ` [PATCH 2] " Rüdiger Sonderfeld
2013-09-30 22:11   ` Rüdiger Sonderfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u4jdgme.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=emacs-devel@gnu.org \
    --cc=kon@iki.fi \
    --cc=ruediger@c-plusplus.de \
    --cc=ttn@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).