unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Przemysław Wojnowski" <esperanto@cumego.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix tramp test
Date: Sun, 22 Feb 2015 15:14:57 +0100	[thread overview]
Message-ID: <871tlighi6.fsf@gmx.de> (raw)
In-Reply-To: <54E9CAA6.8010205@cumego.com> ("Przemysław Wojnowski"'s message of "Sun, 22 Feb 2015 13:25:10 +0100")

Przemysław Wojnowski <esperanto@cumego.com> writes:

> Hello everybody,
>
> A tiny patch for a test that fails in non English systems. OS output summary is
> language dependent and for example in Polish it displays "razem 1234" instead of
> "total 1234".
>
> Please let me know if it can't be applied for some reason.
>
> diff --git a/test/automated/tramp-tests.el b/test/automated/tramp-tests.el
> index 2c4610c..e60a13f 100644
> --- a/test/automated/tramp-tests.el
> +++ b/test/automated/tramp-tests.el
> @@ -955,7 +955,7 @@ This tests also `file-directory-p' and `file-accessible-directory-p'."
>  	     (looking-at-p
>  	      (concat
>  	       ;; There might be a summary line.
> -	       "\\(total.+[[:digit:]]+\n\\)?"
> +	       "\\([[:alpha:]].+[[:digit:]]+\n\\)?"

Better might be "\\([[:alpha:]]+[[:blank:]]+[[:digit:]]+\n\\)?"

>  	       ;; We don't know in which order "." and ".." appear.
>  	       "\\(.+ \\.?\\.\n\\)\\{2\\}"
>  	       ".+ foo$")))))

Beside of this, it looks OK to me. Please apply.

> Thanks!

Best regards, Michael.



  reply	other threads:[~2015-02-22 14:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 12:25 [PATCH] Fix tramp test Przemysław Wojnowski
2015-02-22 14:14 ` Michael Albinus [this message]
2015-02-22 16:00   ` Eli Zaretskii
2015-02-22 16:25     ` Michael Albinus
2015-02-22 17:10       ` Eli Zaretskii
2015-02-22 19:01         ` Michael Albinus
2015-02-22 19:33           ` Przemysław Wojnowski
2015-02-22 20:53           ` Andreas Schwab
2015-02-22 21:46             ` Michael Albinus
2015-02-22 17:07     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tlighi6.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=esperanto@cumego.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).