unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ingo Lohmar <i.lohmar@gmail.com>
To: Tassilo Horn <tsdh@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: include new package wconf.el in GNU ELPA
Date: Thu, 30 Jul 2015 22:58:59 +0200	[thread overview]
Message-ID: <871tfp8ir0.fsf@acer.localhost.com> (raw)
In-Reply-To: <87d1z9a210.fsf@gnu.org>

On Thu, Jul 30 2015 21:17 (+0200), Tassilo Horn wrote:

> Ingo Lohmar <i.lohmar@gmail.com> writes:
>
> Hi Ingo,
>
>> I've been using my small single-purpose package wconf.el
>> https://github.com/ilohmar/wconf for a while now and I am very happy
>> with it.  The code is all mine and I have signed the FSF papers.  Now
>> I would like to put it into an elpa for visibility --- is it ok if I
>> upload it into the GNU elpa (I have commit rights)?
>
> Then I think all prerequisites are set.
>
>> The package does nothing but offer a simple mechanism to switch
>> between different window configurations of a single frame, and to
>> persist them across sessions.
>
> Looks simple and useful.  I'll try it out when I find some spare time.
> I seldomly use window configurations mainly because I don't like that
> window configs also restore point and selected window.  Basically, I'd
> prefer that when I restore a window config, the point values stay as
> they are for all the buffers which are part of the current window config
> and the one I'm switching to.  Likewise, I'd like to have the window
> selected which displays the same buffer as the selected window in the
> current window config in case the window config I'm switching to also
> has a window displaying that buffer.  Does wconf have a knob for that?
> (If not and you add one, you have a new user for sure. :-))
>
> One comment on the code: I dislike the practice of having a normal
> package name and then use an abbreviated prefix in the actual code.
> wconf is a short name anyway, so IMHO there is no benefit of defining
> the functions and variables with the abbreviated wc- prefix instead of
> wconf-.  But there is the obvious downside of likely clashes with
> private stuff from users with the initials WC.  So I'd suggest to change
> that before it pops up in the package list and people start using,
> configuring, and extending it.
>
> A similar thing applies to the file where window configs are stored
> which is currently window-configs.el.  I'd rather go with something
> which makes the connection to your package completely obvious, e.g.,
> wconf-window-configs.el.
>
> Bye,
> Tassilo

Hi Tassilo,

Thanks for your comments!  I have some showstoppers to fix that Dmitry
spotted, and then I'll think about the prefix stuff and will probably
change it.

I have not thought about the point and window business yet, so there's
no option.  Generally I am wary of dealing with window-config details
(which I did in a much earlier version of the package), but this seems
like a general and useful switch to have.. Maybe I will add that.  It
would help me if you could add a github issue describing the option
behavior, otherwise I'll try to keep a note myself.

Bye,
Ingo



  reply	other threads:[~2015-07-30 20:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 15:31 include new package wconf.el in GNU ELPA Ingo Lohmar
2015-07-30 18:57 ` Dmitry Gutov
2015-07-30 19:17 ` Tassilo Horn
2015-07-30 20:58   ` Ingo Lohmar [this message]
2015-07-31  5:35     ` Tassilo Horn
2015-07-31  7:10       ` martin rudalics
2015-07-31  8:27         ` Tassilo Horn
2015-07-31  9:56           ` martin rudalics
2015-07-31 13:39             ` Tassilo Horn
2015-08-01 10:50               ` martin rudalics
2015-08-03  7:45                 ` Tassilo Horn
2015-07-31  9:24       ` Ingo Lohmar
2015-07-31  7:10   ` martin rudalics
2015-07-31  8:37     ` Tassilo Horn
2015-07-31  9:56       ` martin rudalics
2015-07-31 13:56         ` Tassilo Horn
2015-08-01 10:50           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tfp8ir0.fsf@acer.localhost.com \
    --to=i.lohmar@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).