From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: phillip.lord@russet.org.uk (Phillip Lord)
Newsgroups: gmane.emacs.devel
Subject: fix/ert-multiline-explanation
Date: Wed, 21 Oct 2015 21:43:14 +0100
Message-ID: <871tco2brx.fsf@russet.org.uk>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1445460219 28357 80.91.229.3 (21 Oct 2015 20:43:39 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Wed, 21 Oct 2015 20:43:39 +0000 (UTC)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 22:43:30 2015
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Zp0EI-0001dy-1u
	for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 22:43:26 +0200
Original-Received: from localhost ([::1]:53931 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Zp0EG-0002oh-MH
	for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 16:43:24 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phillip.lord@newcastle.ac.uk>) id 1Zp0ED-0002nQ-1v
	for emacs-devel@gnu.org; Wed, 21 Oct 2015 16:43:21 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phillip.lord@newcastle.ac.uk>) id 1Zp0E8-0007cC-Va
	for emacs-devel@gnu.org; Wed, 21 Oct 2015 16:43:20 -0400
Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:45907)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phillip.lord@newcastle.ac.uk>) id 1Zp0E8-0007aU-Oh
	for emacs-devel@gnu.org; Wed, 21 Oct 2015 16:43:16 -0400
Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk)
	by cheviot22.ncl.ac.uk with esmtp (Exim 4.63)
	(envelope-from <phillip.lord@newcastle.ac.uk>) id 1Zp0E6-0001Gi-G2
	for emacs-devel@gnu.org; Wed, 21 Oct 2015 21:43:15 +0100
Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46]
	helo=localhost)
	by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
	(envelope-from <phillip.lord@newcastle.ac.uk>) id 1Zp0E6-0006nq-Qt
	for emacs-devel@gnu.org; Wed, 21 Oct 2015 21:43:14 +0100
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 128.240.234.22
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:192329
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/192329>


I would appreciate feedback on whether the change on
fix/ert-multiline-explanation would be a good one.

At the moment, ert allows you to attach explanation functions to explain
why tests have failed. Unfortunately, these explanations are printed out
using "pp" which escapes new lines. So multiline explanations are,
largely, unreadable.

So this patch ignores the value of pp-escape-newlines and resets it to
nil for the duration.