From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: reftex.el autoloads Date: Fri, 18 Dec 2015 20:55:24 +0000 Message-ID: <871tajiiir.fsf@russet.org.uk> References: <87h9jqo9a5.fsf@russet.org.uk> <87poycvrp7.fsf@russet.org.uk> <566B2BFC.1070802@cs.ucla.edu> <877fkj1q5j.fsf@russet.org.uk> <83si375x03.fsf@gnu.org> <8737v71oo0.fsf@russet.org.uk> <83r3ir5vrb.fsf@gnu.org> <87y4czz7ul.fsf@russet.org.uk> <83oadv58fm.fsf@gnu.org> <87h9jmks0u.fsf@russet.org.uk> <87zixexam5.fsf@russet.org.uk> <0ltwnjbj6q.fsf@fencepost.gnu.org> <87zixagvs4.fsf@russet.org.uk> <83io3xzqo3.fsf@gnu.org> <877fkcyd7r.fsf@russet.org.uk> <56743E61.8060102@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1450472148 19843 80.91.229.3 (18 Dec 2015 20:55:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Dec 2015 20:55:48 +0000 (UTC) Cc: Glenn Morris , Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 18 21:55:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aA23u-00072g-8W for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 21:55:38 +0100 Original-Received: from localhost ([::1]:35064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA23t-0005fX-LJ for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 15:55:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA23o-0005fN-B8 for emacs-devel@gnu.org; Fri, 18 Dec 2015 15:55:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aA23n-0002MH-8B for emacs-devel@gnu.org; Fri, 18 Dec 2015 15:55:32 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:44092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA23h-0002Kv-R4; Fri, 18 Dec 2015 15:55:25 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1aA23h-0003IU-Cx; Fri, 18 Dec 2015 20:55:25 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1aA23g-0004hU-Qw; Fri, 18 Dec 2015 20:55:24 +0000 In-Reply-To: <56743E61.8060102@cs.ucla.edu> (Paul Eggert's message of "Fri, 18 Dec 2015 09:12:01 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196490 Archived-At: Paul Eggert writes: > On 12/18/2015 08:39 AM, Glenn Morris wrote: >> Somewhat disappointed, but obviously I'm in a minority. >> Anyway, it doesn't build. Did you test it? > > Yes, I suggest reverting the change from master until it's tested and known to > work from a fresh checkout. > > Here are a couple of other comments. That's not the right way to declare > autoloads-force to be phony. I thought it was an usual usage, but I copied it from autoloads. I guess: autoloads-force .PHONY: rm loaddefs.el $(MAKE) autoloads should be autoloads-force: rm loaddefs.el $(MAKE) autoloads .PHONY: autoloads-force > Also, there shouldn't need to be an autoloads-force at all: if some > other files need to be built they should be listed as dependencies of > autoload. Indeed. It's always been this way, though -- from a non-bootstrap on emacs-25 try rm lisp/eshell/esh-groups.el make ./src/emacs -Q M-x eshell It will crash. What you actually have to do is cd lisp rm loaddefs.el make autoloads The problem is that files are not dependencies, they are targets which are build at the same time as loaddefs.el. AFAICT, there is no good way of dealing with this in make (and perhaps there should be). It is fixable, but it requires significant modifications to autoloads.el, and will substantially complicate lisp/Makefile.in. I didn't want to make that change, for fear of disappointing Glenn further. This is a minimal change, and was quite useful was I was producing my (ill-tested) set of commits. Phil