From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Emacs Git make bootstrap failure - idna related Date: Mon, 28 Dec 2015 19:18:07 +0100 Message-ID: <871ta6v3mo.fsf@gnus.org> References: <87wpryv7eu.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451326743 14191 80.91.229.3 (28 Dec 2015 18:19:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 18:19:03 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 19:18:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDcNg-00065n-FO for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 19:18:52 +0100 Original-Received: from localhost ([::1]:45732 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcNf-00039V-Qm for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 13:18:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcNR-00039O-QM for emacs-devel@gnu.org; Mon, 28 Dec 2015 13:18:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDcNO-00009P-4s for emacs-devel@gnu.org; Mon, 28 Dec 2015 13:18:37 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:51575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcNN-00009A-U9 for emacs-devel@gnu.org; Mon, 28 Dec 2015 13:18:34 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDcMy-0003eu-LU for emacs-devel@gnu.org; Mon, 28 Dec 2015 19:18:08 +0100 In-Reply-To: <87wpryv7eu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Dec 2015 17:56:25 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aDcMy-0003eu-LU MailScanner-NULL-Check: 1451931489.8743@YM5+eixN2wfivbztSK5npQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197025 Archived-At: Lars Ingebrigtsen writes: > Also, does anybody have an opinion on where Emacs should do IDNA > decoding? Since any service can theoretically be located on an IDNA > name, I think the most likely place to do it is in > `open-network-stream'. Then both > > (open-network-stream ... "m=E9xico.icom.museum" "imap") > > and > > `M-x eww http://m=E9xico.icom.museum' > > would work without doing much work in all the different libraries... > > (Hm, url.el seems do be doing URL-encoding on the host name at present, so > that'll have to be fixed.) I've now made these changes, but haven't pushed them yet. I'm now able to visit that Mexican museum site with eww. :-) The changes are basically (make-network-process :name name :buffer buffer - :host host :service service + :host (puny-encode-domain host) :service service in the calls to `make-network-process' in network-stream.el. `puny-encode-domain' is a NOP for all normal, non-IDNA domain names, so the potential for breakage should be pretty small... Does anybody object to this change, or have a suggestion as to how to do this in a different way? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no