From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Code reviews Date: Wed, 09 Mar 2016 15:06:47 +0000 Message-ID: <871t7j4rnc.fsf@russet.org.uk> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <878u1tuzgn.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457536041 18908 80.91.229.3 (9 Mar 2016 15:07:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Mar 2016 15:07:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 09 16:07:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adfhb-0008UF-TP for ged-emacs-devel@m.gmane.org; Wed, 09 Mar 2016 16:07:08 +0100 Original-Received: from localhost ([::1]:42024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adfhX-0008R5-RM for ged-emacs-devel@m.gmane.org; Wed, 09 Mar 2016 10:07:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adfhP-0008Qa-BH for emacs-devel@gnu.org; Wed, 09 Mar 2016 10:07:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adfhJ-00040z-HL for emacs-devel@gnu.org; Wed, 09 Mar 2016 10:06:55 -0500 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:39425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adfhJ-00040n-7h for emacs-devel@gnu.org; Wed, 09 Mar 2016 10:06:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=A6dJk5YHi/DUXviTCa8V3HzxvKSm7hsm7Mdc1cS1XQ8=; b=vgkXoTEe8adJl90CVkNefi/eg/ LNJvU9VAu1J7T+zQ0BCfqBPWXQvoYZH0qEUIaaFfdrqiM7hVPs3Qw0Fx/aeV/7kTVmxmE2jjraez9 64aM6fKvbSf9fs7qfBhySjhjqdMmXiUcxLE2FOvxmkibwpcLmtE43awWL2/EHdCGi4rH69DELedQ1 9iJEHriX25+4JjSyV3bymgvKgWb7f2L7masImZQzWeEbEceGJFKXDRpGM7RvwZow0EzXfYRv1eRSQ CxIC8pSrQ3UUiHhHwg8RgqVfvrV22+7/pBwEXLLue3Ts0FOHw5e/E+1z++zN1eaCjVUSnXC1ZAmmg DWXOQGxQ==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:35350 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86) (envelope-from ) id 1adfhH-0035X9-Tk; Wed, 09 Mar 2016 15:06:47 +0000 In-Reply-To: (Stefan Monnier's message of "Tue, 08 Mar 2016 08:27:41 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201242 Archived-At: Stefan Monnier writes: >>> Maybe we could have a half-way system, where commits are pushed to >>> a branch that is "not fast-forward-only", and this branch is then >>> auto-merged to the real (fast-forward-only) master branch after a delay >>> (one day, maybe?) to give time to fix mess ups before they're cast >>> in stone. >> I think that this would require some considerable co-ordination. If I >> push a broken commit to devel branch, and then you fix this commit >> through rebase, my copy of the branch (and everyone elses) is now >> broken. I'm pretty sure that this kind of fix up can only happen on a >> feature branch in a sane way. > > I think you misunderstood me: what I was thinking about in the quoted > text is a system where you submit a pull request to a review queue (not > to some kind of shared "proto-master" branch), and those requests are > automatically accepted after some timeout. Oh. You mean "where commits are pushed to a branch" as in "some branch" rather than "all commits are pushed to a specific branch". So, essentially a PR system with a time out. That would be quite nice. Phil