From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: run tests from el files Date: Mon, 27 Jun 2016 21:41:16 +0100 Message-ID: <871t3is6tv.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1467060155 10904 80.91.229.3 (27 Jun 2016 20:42:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2016 20:42:35 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 27 22:42:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bHdMO-0000Te-K9 for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 22:42:24 +0200 Original-Received: from localhost ([::1]:32773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHdMN-00042T-Or for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 16:42:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHdLP-0003n9-Ne for emacs-devel@gnu.org; Mon, 27 Jun 2016 16:41:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHdLJ-0006XU-Pl for emacs-devel@gnu.org; Mon, 27 Jun 2016 16:41:22 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:38877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHdLJ-0006XN-FP for emacs-devel@gnu.org; Mon, 27 Jun 2016 16:41:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From; bh=iZdQ4UD/ZYdxXCx8NwUA5ozMbzWQXd6Zd/RgspdbM2w=; b=nCo917CUk nku2gKD7FGQK/spr6M938H6Rxagus8ToNsh+g33Fr8kFhjUb9I5qOWZbtLUTvM7SUa7AjrHrCVX+2 qRvKTbq8SmDFCugkpkuowj9WuS50tPzUIwEQuxqZIbhGcw3v18uqvbSJCi5A2FInjhXTkUTLjLUfE VTZtloXIStAsq0vzqSH6UxHgryc1+PiiGolpaLq8X/WWVcax+bkVlEK/U8GIDZEliu8+e736PVNss UGOolCjb/50lf+WTbHXOkcbn/DnL5eyKAv60CZqpSZL9LNEQKsGh/rOVHgcz6Zuz6xqD7/f4ux7S3 ucG6orBHmjZeNuDrWi+wbcetw==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:52773 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bHdLI-003Ekm-Nq for emacs-devel@gnu.org; Mon, 27 Jun 2016 21:41:16 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204837 Archived-At: --=-=-= Content-Type: text/plain I would like comments on this patch which I'd like to install on master. The idea is to run tests of the .el files because they give nicer stacktraces. I can see no downsides to this, but I don't understand why the .elc files were used in the first place, so wanted to ask. Phil --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-undo-boundary-always.patch From: Phillip Lord Date: Fri, 17 Jun 2016 22:34:50 +0100 Subject: [PATCH] Fix missing undo-boundary after revert-buffer * lisp/simple.el (undo-auto--boundaries): Ensure an undo-boundary after every command whether it (apparently) changes the buffer or not. Addresses Bug#23785 --- lisp/simple.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/simple.el b/lisp/simple.el index b66827d..3110430 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2875,6 +2875,10 @@ undo-auto--boundaries "Check recently changed buffers and add a boundary if necessary. REASON describes the reason that the boundary is being added; see `undo-last-boundary' for more information." + ;; (Bug #23785) All commands should ensure that there is an undo + ;; boundary whether they have changed the current buffer or not. + (when (eq cause 'command) + (add-to-list 'undo-auto--undoably-changed-buffers (current-buffer))) (dolist (b undo-auto--undoably-changed-buffers) (when (buffer-live-p b) (with-current-buffer b -- 2.8.4 --=-=-=--