From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Sun, 25 Dec 2016 18:48:00 +0900 Message-ID: <871sww2vcf.fsf@gmail.com> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> <9fe241fa-d4ee-6e44-bfdd-99cb6b4ab4e4@yandex.ru> <87fultr4he.fsf@secretsauce.net> <877f6v2vc1.fsf@gmail.com> <87inq8ec05.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482659304 19635 195.159.176.226 (25 Dec 2016 09:48:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2016 09:48:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Dmitry Gutov , Tino Calancha , emacs-devel@gnu.org To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 25 10:48:18 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL5PX-0003RY-EU for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 10:48:11 +0100 Original-Received: from localhost ([::1]:46289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL5PZ-0004qP-Tl for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 04:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL5PT-0004qB-Ol for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cL5PS-0003Ri-Se for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:48:07 -0500 Original-Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:34201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cL5PS-0003RW-NI for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:48:06 -0500 Original-Received: by mail-pf0-x244.google.com with SMTP id y68so15765121pfb.1 for ; Sun, 25 Dec 2016 01:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AIXS9au9y9gudQmNaRgRsXXmB27bnDHLJwGsxdxFQPo=; b=QiSJ84Lo1mPrJWkFyJsLkVwm/+zG75XWJVcJFkeMknkeMZ9k0uxBDJmsKbVB7HDuJg QE9HP10/1uHiRAzKO35l1AE7JC1OxOZ14+Lax+NEsnzv5hyowTIvvpxLfl8rNPIu2DeW J6ewL7GyLe9Wl/7SdD7sShfrWa8ZQZQNU/DeYHZR6WU0t6gIQ1NSkVe4K6SJfp2oxl/y SMhYTJ7C9BUbAqyAtMzpww0P1n+gCodScRjhw2DhF+C1w8Dmt8wW1JNVk6PE2DDMIpdU rcKsZGDVu0Kjfdmcxt1obGt0KC2NL6IJxnCrT4/MYvwsCrrI9WJC0qJaZ+Jrg+mb3Fwr +XfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AIXS9au9y9gudQmNaRgRsXXmB27bnDHLJwGsxdxFQPo=; b=RWIcVb9SRdmA4GGv+zYsVOnTlXq+FW8AptrewFteq7Agc3gJBG8NRwBuva/U8Uf3Yl MtWWrxHcuGVCmsUwjVLjQVTBCCvGeXJHtT/vXGeIs8XPYp7OeXL3X7aJxBzarb7a524+ JkYdddNYrVrZAfnS8g+YgJ/L6BEonyzsdkbhNsm9M9HWpC0MRP22iC6F3vpKYcDRl6B7 5L0Ly61qyrmFunPja9sbpO5AE/BQSlcUGywXeQdE4paPH/tgbmwV483mEphw7Y5/zG98 Kh2i9eHBe4EJrjhfZyuWLFPbLswpR6d14suSY7tdG9BsIvoGqQRvnZqY0YICeDwqpl2V 2M8w== X-Gm-Message-State: AIkVDXIOcT4824mxgv+Q/DF8DzsWXHjBrYuYy9QlZgb0pQ3EFvVx0jC2daoCXamwNfBRgw== X-Received: by 10.84.232.200 with SMTP id x8mr13515552plm.1.1482659285253; Sun, 25 Dec 2016 01:48:05 -0800 (PST) Original-Received: from calancha-pc ([240f:6e:c111:1:87d4:550f:514f:c022]) by smtp.gmail.com with ESMTPSA id o24sm23793123pfj.78.2016.12.25.01.48.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Dec 2016 01:48:04 -0800 (PST) In-Reply-To: <87inq8ec05.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 24 Dec 2016 22:52:42 -0800") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210799 Archived-At: Dima Kogan writes: > Tino Calancha writes: > >> Hi Dima, >> after commit 2c8a7e5 the following receipt doesn't work: >> >> M-! git show HEAD RET >> C-x o >> C-x C-q >> M-x diff-mode RET >> n >> ;; Signal error: >> diff-beginning-of-file-and-junk: Can t find the beginning of the file >> >> I use above code very often: before commit 2c8a7e5, it skips the commit >> message and jumps to the first hunk. >> Is it possible to make above snippet working as before? > > Hi. I pushed to master the fix to this and the logic to invoke the > auto-refinement only if the preceding motion was successful. Thank you. I think is not working as before. Consider following snippet code: M-! git show SHA1 RET C-x b *Shell Command Output* RET C-x C-q M-x diff-mode n When i use as SHA1 e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97 previous commands successfully move point to next hunk. But if i use commit 6b6abe0dba6a9a2e5f78aac3814421886e7a184f then they don't work; i got the following error: user-error: No next hunk I am wondering why the second commit behaves differently than the first one. Regards, Tino