From: Tino Calancha <tino.calancha@gmail.com>
To: Dima Kogan <lists@dima.secretsauce.net>
Cc: Dmitry Gutov <dgutov@yandex.ru>,
Tino Calancha <tino.calancha@gmail.com>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation
Date: Sun, 25 Dec 2016 18:48:00 +0900 [thread overview]
Message-ID: <871sww2vcf.fsf@gmail.com> (raw)
In-Reply-To: <87inq8ec05.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 24 Dec 2016 22:52:42 -0800")
Dima Kogan <lists@dima.secretsauce.net> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> Hi Dima,
>> after commit 2c8a7e5 the following receipt doesn't work:
>>
>> M-! git show HEAD RET
>> C-x o
>> C-x C-q
>> M-x diff-mode RET
>> n
>> ;; Signal error:
>> diff-beginning-of-file-and-junk: Can t find the beginning of the file
>>
>> I use above code very often: before commit 2c8a7e5, it skips the commit
>> message and jumps to the first hunk.
>> Is it possible to make above snippet working as before?
>
> Hi. I pushed to master the fix to this and the logic to invoke the
> auto-refinement only if the preceding motion was successful.
Thank you.
I think is not working as before.
Consider following snippet code:
M-! git show SHA1 RET
C-x b *Shell Command Output* RET
C-x C-q
M-x diff-mode
n
When i use as SHA1
e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97
previous commands successfully move point to next hunk.
But if i use commit
6b6abe0dba6a9a2e5f78aac3814421886e7a184f
then they don't work; i got the following error:
user-error: No next hunk
I am wondering why the second commit behaves differently than
the first one.
Regards,
Tino
next prev parent reply other threads:[~2016-12-25 9:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 12:07 [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Tino Calancha
2016-11-30 0:03 ` Noam Postavsky
2016-11-30 14:22 ` Dmitry Gutov
2016-11-30 14:31 ` Stefan Monnier
2016-11-30 14:34 ` Dmitry Gutov
2016-11-30 15:07 ` Stefan Monnier
2016-12-10 1:27 ` Dima Kogan
2016-12-10 10:14 ` Dmitry Gutov
2016-12-10 17:27 ` Dima Kogan
2016-12-11 11:07 ` Dmitry Gutov
2016-12-12 7:28 ` Dima Kogan
2016-12-16 1:05 ` Dmitry Gutov
2016-12-20 2:22 ` Tino Calancha
2016-12-20 7:31 ` Dima Kogan
2016-12-25 6:52 ` Dima Kogan
2016-12-25 9:48 ` Tino Calancha [this message]
2016-12-25 9:58 ` Tino Calancha
2016-12-25 14:10 ` Dmitry Gutov
2016-12-06 2:03 ` Mark Oteiza
2016-12-07 7:29 ` Dima Kogan
2017-01-06 2:58 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sww2vcf.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=lists@dima.secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).