Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation

[Tino Calancha <tino.calancha@gmail.com>]

Dima Kogan <lists@dima.secretsauce.net> writes:

> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> Hi Dima,
>> after commit 2c8a7e5 the following receipt doesn't work:
>>
>> M-! git show HEAD RET
>> C-x o
>> C-x C-q
>> M-x diff-mode RET
>> n
>> ;; Signal error:
>> diff-beginning-of-file-and-junk: Can t find the beginning of the file
>>
>> I use above code very often: before commit 2c8a7e5, it skips the commit
>> message and jumps to the first hunk.
>> Is it possible to make above snippet working as before?
>
> Hi. I pushed to master the fix to this and the logic to invoke the
> auto-refinement only if the preceding motion was successful.

Thank you.
I think is not working as before.
Consider following snippet code:

M-! git show SHA1 RET
C-x b *Shell Command Output* RET
C-x C-q
M-x diff-mode
n

When i use as SHA1
e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97
previous commands successfully move point to next hunk.

But if i use commit
6b6abe0dba6a9a2e5f78aac3814421886e7a184f
then they don't work; i got the following error:
user-error: No next hunk

I am wondering why the second commit behaves differently than
the first one.

Regards,
Tino