From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars. Date: Fri, 10 Feb 2017 06:15:04 +0100 Message-ID: <871sv6mxt3.fsf@zigzag.favinet> References: <20170208091858.6699.16542@vcs.savannah.gnu.org> <20170208091858.F26CA220010@vcs.savannah.gnu.org> <87a89vmff5.fsf@zigzag.favinet> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1487026473 10775 195.159.176.226 (13 Feb 2017 22:54:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Feb 2017 22:54:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 13 23:54:27 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdPVp-00027y-D3 for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 23:54:25 +0100 Original-Received: from localhost ([::1]:59997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdPVr-0001K3-Ne for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 17:54:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdPVK-0001Ju-Tx for emacs-devel@gnu.org; Mon, 13 Feb 2017 17:53:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdPVH-00010B-Ol for emacs-devel@gnu.org; Mon, 13 Feb 2017 17:53:54 -0500 Original-Received: from mail.agora-net.com ([67.59.132.6]:56928) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cdPVH-0000zw-KU for emacs-devel@gnu.org; Mon, 13 Feb 2017 17:53:51 -0500 Original-Received: from ttn by mail.agora-net.com with local (Exim 4.82) (envelope-from ) id 1cdPVF-0006WV-FA for emacs-devel@gnu.org; Mon, 13 Feb 2017 17:53:49 -0500 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1cc3YE-0003MI-5s for emacs-devel@gnu.org; Fri, 10 Feb 2017 06:15:18 +0100 Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Thu, 09 Feb 2017 13:02:22 -0500") X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ttn@gnuvola.org X-SA-Exim-Scanned: No (on mail.agora-net.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 67.59.132.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212354 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () Stefan Monnier () Thu, 09 Feb 2017 13:02:22 -0500 > (defvar MODE-map INIT) ; model C > (define-derived-mode MODE ...) This is the idiomatic form. OK, noted. The main benefit is that there's a clear place where the mode map is defined and `C-h o` will get you there. Thanks for the tip. =E2=80=98C-h o=E2=80=99 is new to me. That's indeed a= nice benefit. aesthetic problem is due to the use forward references. So, is it fair to say that the reason for the patch was to avoid those forward references? Yes, exactly. > (unless EXPECTED-MODE-map-BINDING Of course, this misfires if the user wants to change this EXPECTED-MODE-map-BINDING binding ;-) True, that's the risk. I'll release, wait a year or two for complaints, and revisit the decision then -- perhaps =E2=80=98C-h o=E2=80=99 will in the meantime learn= how to accomodate some non-idiomatic forms, such as this one. =2D-=20 Thien-Thi Nguyen ----------------------------------------------- (defun responsep (query) (pcase (context query) (`(technical ,ml) (correctp ml)) ...)) 748E A0E8 1CB8 A748 9BFA =2D-------------------------------------- 6CE4 6703 2224 4C80 7502 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlidTFsACgkQZwMiJEyAdQKh4gCfd5DpjOS4BzHmtYmXya8yn5cI yfAAn3fLEY4iHf2G8HJjp/L76xFCDX82 =cqZr -----END PGP SIGNATURE----- --=-=-=--