From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Merging Org tests Date: Tue, 14 Feb 2017 20:16:33 +0100 Message-ID: <871sv01t2m.fsf@gmx.de> References: <871sv0oljt.fsf@gmx.us> <87lgt8myhm.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487099859 8222 195.159.176.226 (14 Feb 2017 19:17:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Feb 2017 19:17:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Rasmus , emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 14 20:17:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdibV-0001fb-S5 for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2017 20:17:34 +0100 Original-Received: from localhost ([::1]:36719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdibb-0006Gi-CF for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2017 14:17:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdibU-0006Ga-LE for emacs-devel@gnu.org; Tue, 14 Feb 2017 14:17:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdibR-00030P-8a for emacs-devel@gnu.org; Tue, 14 Feb 2017 14:17:32 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:57840) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cdibQ-0002zm-Ue for emacs-devel@gnu.org; Tue, 14 Feb 2017 14:17:29 -0500 Original-Received: from detlef.gmx.de ([93.197.208.35]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MZlEg-1cy0693NGg-00LV34; Tue, 14 Feb 2017 20:16:36 +0100 In-Reply-To: <87lgt8myhm.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 14 Feb 2017 18:13:57 +0000") X-Provags-ID: V03:K0:3rKQj2OHmy5FWpLlxbS/uzHXBtvTX2fAe1WZudGnJS8iPljP3IS e0tC+QsINDcqjAbz5Dg5AcOKdYtZA7BVTwfHoeTbwCayTCKK3Yw7RmOc9TBCtfwgMd2Rw/p pjCUp0BemOd0KJdGxGx6o77p9okWrf0oPGfhvKi/ND6t9/kYDKkJjlpmh7C/qXpRTwwQ5rq CcsqanzYWjJzKNZ4fszDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:g3Wx0llbhZI=:nQ1tIV4IuuCqCijz60FZ7C TVTRRREUYi2Q/JAsblr20p4IU45Q2LL6+NnIg7f9ARPtvOsYT9vinIUSCKZYYOgYmnGyM4YVq UQsHSRgU6mGM4RJvIn+Uyl/0YaWraOSjG2xQqc6fwKBdOC7dUiTgomdjJ2yB2mr7mSuwLTWF/ +N6M1RmV3mJCVDS0hB8Cia2lJ7/hHqGLVXLVOsB2HMZRDh5O0IIRmIHWDHGidE6aWrR8Fao1U ZJhJ319z9gx+a2cyxIqWTvgpgLQjggepn4yaXX0bwMsixcIXgtcu4vJyjZa8F67Jpm9W91lz+ 3udu8ccFnmJ7ZFNDuAM2XRBHIUUyRSTL5FuR5Y/v4Rxd6Czu14mkcs8WI6Blv0YIvBpe1X1D9 qdHli1ne9BubpCm717xNjDGuiuEIhLpxuRPT43OlYOO3N4+yPiLU6zwaHYpi3L/WNCTch36fM ZtDn7mUX2Lq590xXKGGY0eTMBViVh7kUjTb4am2lzgrVej/Ea1wbYBYceW2zqysPwL9Y7wTgt c3DLb+0NIcPPJ7nfhxC/uGsp/wdLdIQIYz7VL6MM2FHllbmrmk3bsMciR8uVDyr8c6Wh1PtXa YMjGTpI5j6u9gyds5cl1gNyFXSMNBll+EeQ1RmA0jsG2n/R8IAj40/xbGBCkUhYAzx7EEnbzX F/vQyE2oqPdH4lmoBkOMV4m+O9C3rzrriEfcZvUqMY4lP4Lx6dTemeAa06pUgQTtrTv6hLFdF RGjBqU+NC9j3GW86oybrpPkXxwJzF+I+1nsGpDHxBo2VhQLVuHYcdJrJER7SESxzavzpMO2j X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212383 Archived-At: phillip.lord@russet.org.uk (Phillip Lord) writes: >> Also, how strictly must the suggested file organization be followed? >> Skimming "make-test-deps.emacs-lisp" it seems it might have to be followed >> rather strictly. > > It depends what you want. make-test-deps.emacs-lisp is there so that > "make check-maybe" can work sanely to run (some approximation of) just > those tests that need running. I thought this was a good thing to have, > because "make check" takes too long to run in a commit hook. In general it is a good thing (tm). But there shall be improvements. Currently, if you want to run foo-tests.el, it depends on foo.el. Often, this is sufficient. But for larger packages, like Org or Tramp, this is not sufficient. So it might be good to maintain a list of foo*.el files, a test file foo-tests.el shall depend on. >> What would be the best strategy for including the Org tests in the Emacs >> repo? >> >> 1. Include Org tests in the "manual" folder and keep the current structure. >> 2. Start to reorganize the tests in the Org repo to follow the Emacs >> scheme. >> 3. Keep tests in the Org repo. > > Really be good to get tests in into main, so not 3. That's the main > thing. Like Eli, I'm in favor of 2. And pls mark expensive tests with the tag `expensive'. We should teach elpa's "make check" to skip expensive tests, as we do in emacs' "make check". > Phil Best regards, Michael.