Re: master 089b159 02/12: change calc to use derived-mode-p

Re: master 089b159 02/12: change calc to use derived-mode-p

[Mark Oteiza]

tom@tromey.com (Tom Tromey) writes:

>     change calc to use derived-mode-p
>     
>     * lisp/calc/calc-embed.el (calc-embedded-find-modes)
>     (calc-embedded-make-info): Use derived-mode-p.
> ---
>  lisp/calc/calc-embed.el | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/calc/calc-embed.el b/lisp/calc/calc-embed.el
> index bb37d7f..bd5601b 100644
> --- a/lisp/calc/calc-embed.el
> +++ b/lisp/calc/calc-embed.el
> @@ -804,7 +804,7 @@ The command \\[yank] can retrieve it from there."
>        (backward-char 6))
>      (goto-char save-pt)
>      (unless (assq 'the-language modes)
> -      (let ((lang (assoc major-mode calc-language-alist)))
> +      (let ((lang (cl-assoc-if #'derived-mode-p calc-language-alist)))
>          (if lang
>              (setq modes (cons (cons 'the-language (cdr lang))
>                                modes)))))
> <snip>

At first sight: neither calc, viper, nor align use cl-lib, so these
changes break things.

Re: master 089b159 02/12: change calc to use derived-mode-p

[Tom Tromey]

>>>>> "Mark" == Mark Oteiza <mvoteiza@udel.edu> writes:

Mark> At first sight: neither calc, viper, nor align use cl-lib, so these
Mark> changes break things.

I'll give them a better try tomorrow.
My belief was that these functions are autoloaded so no special case is
needed.  Is that not so?

Tom

Re: master 089b159 02/12: change calc to use derived-mode-p

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> My belief was that these functions are autoloaded so no special case is
Tom> needed.  Is that not so?

Yep, that's totally wrong.
I am testing a fix.

Tom