From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Mon, 17 Apr 2017 00:15:00 +0300 Organization: LINKOV.NET Message-ID: <871ssscauz.fsf@localhost> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <58F06DC0.8090505@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1492377589 30286 195.159.176.226 (16 Apr 2017 21:19:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 21:19:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 23:19:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czra6-0007c5-3s for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 23:19:38 +0200 Original-Received: from localhost ([::1]:33590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czra8-0006HU-Tx for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 17:19:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czra1-0006HD-Sv for emacs-devel@gnu.org; Sun, 16 Apr 2017 17:19:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czra1-0005Mi-4r for emacs-devel@gnu.org; Sun, 16 Apr 2017 17:19:33 -0400 Original-Received: from hapkido.dreamhost.com ([66.33.216.122]:44701) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1czrZx-0005KY-9N; Sun, 16 Apr 2017 17:19:29 -0400 Original-Received: from homiemail-a75.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id 9B2308559F; Sun, 16 Apr 2017 14:19:25 -0700 (PDT) Original-Received: from homiemail-a75.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTP id 798705EC079; Sun, 16 Apr 2017 14:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=jurta.org; bh=BJb0Ovr itIBQknVydJw7fwhseQQ=; b=KVe4M9Fe4ehf19W3ofjTqK0yCSmSLtDhOHM7rDJ FVlroLdvrWSxg8xHUw+mTbk4c0BIe2kw5Km0vLm1QxxIbx+r1vea0dTjWw+4utQV RvlgZaozKvJsXkPjZGXT3IKG+5dQa7d7RcqRFgwytkKEuWW7OkGbtaSgWEPjo+Y6 UA9c= Original-Received: from localhost.linkov.net (m90-133-225-157.cust.tele2.ee [90.133.225.157]) (Authenticated sender: jurta@jurta.org) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTPA id 47CC75EC05C; Sun, 16 Apr 2017 14:19:22 -0700 (PDT) In-Reply-To: <58F06DC0.8090505@gmx.at> (martin rudalics's message of "Fri, 14 Apr 2017 08:35:44 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 66.33.216.122 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214028 Archived-At: >> I'm sure that all these callers used kill-this-buffer because there wa= s no >> kill-current-buffer to simply kill the current buffer, and nothing mor= e. > > Do you mean because it was too tedious to write (kill-buffer nil)? Yes, as a command it is easier to use kill-current-buffer from M-x or bind it to a key. >> So I think we need to leave kill-this-buffer callers only in menu-bar/= tool-bar, >> and use kill-current-buffer everywhere else, leaving just >> =E2=80=98(kill-buffer (current-buffer))=E2=80=99 in the definition of >> kill-current-buffer in simple.el. > > Why (kill-buffer (current-buffer))? Isn't (kill-buffer) enough? (kill-buffer (current-buffer)) is more explicit. I think there are other parts of kill-this-buffer/kill-current-buffer that need to be simplified.