From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>,
monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466)
Date: Mon, 17 Apr 2017 00:15:00 +0300 [thread overview]
Message-ID: <871ssscauz.fsf@localhost> (raw)
In-Reply-To: <58F06DC0.8090505@gmx.at> (martin rudalics's message of "Fri, 14 Apr 2017 08:35:44 +0200")
>> I'm sure that all these callers used kill-this-buffer because there was no
>> kill-current-buffer to simply kill the current buffer, and nothing more.
>
> Do you mean because it was too tedious to write (kill-buffer nil)?
Yes, as a command it is easier to use kill-current-buffer from M-x
or bind it to a key.
>> So I think we need to leave kill-this-buffer callers only in menu-bar/tool-bar,
>> and use kill-current-buffer everywhere else, leaving just
>> ‘(kill-buffer (current-buffer))’ in the definition of
>> kill-current-buffer in simple.el.
>
> Why (kill-buffer (current-buffer))? Isn't (kill-buffer) enough?
(kill-buffer (current-buffer)) is more explicit. I think there are other
parts of kill-this-buffer/kill-current-buffer that need to be simplified.
next prev parent reply other threads:[~2017-04-16 21:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170412194437.19648.75020@vcs0.savannah.gnu.org>
[not found] ` <20170412194438.934FD22EE8@vcs0.savannah.gnu.org>
2017-04-12 20:27 ` [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Stefan Monnier
2017-04-12 22:03 ` Juri Linkov
2017-04-13 6:41 ` Eli Zaretskii
2017-04-13 23:35 ` Juri Linkov
2017-04-14 6:35 ` martin rudalics
2017-04-16 21:15 ` Juri Linkov [this message]
2017-04-14 7:27 ` Eli Zaretskii
2017-04-16 13:42 ` Stefan Monnier
2017-04-16 15:21 ` martin rudalics
2017-04-16 19:18 ` Stefan Monnier
2017-04-16 20:37 ` martin rudalics
2017-04-16 16:54 ` Eli Zaretskii
2017-04-16 19:22 ` Stefan Monnier
2017-04-16 20:07 ` Eli Zaretskii
2017-04-17 3:00 ` Stefan Monnier
2017-04-17 5:39 ` Eli Zaretskii
2017-04-17 12:14 ` Stefan Monnier
2017-04-17 14:35 ` Eli Zaretskii
2017-04-17 16:05 ` Stefan Monnier
2017-04-17 16:52 ` Eli Zaretskii
2017-04-19 12:12 ` Stefan Monnier
2017-04-17 14:25 ` Richard Stallman
2017-04-13 18:37 ` Stefan Monnier
2017-04-13 23:30 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ssscauz.fsf@localhost \
--to=juri@jurta.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).