From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Mon, 15 Oct 2018 21:09:44 -0500 Message-ID: <871s8qzlp3.fsf@red-bean.com> References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <9f2ed5a8-96c0-aa6c-b9c8-3b0f73f20aa6@luyten.fr> <357cd187-ad96-4cc6-9c01-cca87282f165@default> <8736taoo4y.fsf@red-bean.com> <6a73c984-002a-f767-6a96-3fb0822489de@luyten.fr> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539655713 24149 195.159.176.226 (16 Oct 2018 02:08:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2018 02:08:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Drew Adams , emacs-devel@gnu.org To: Pierre-Yves Luyten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 16 04:08:28 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCEma-0006DG-Fs for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2018 04:08:28 +0200 Original-Received: from localhost ([::1]:55616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCEog-000168-Ex for ged-emacs-devel@m.gmane.org; Mon, 15 Oct 2018 22:10:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCEnv-000163-L0 for emacs-devel@gnu.org; Mon, 15 Oct 2018 22:09:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCEnr-0002KV-Kh for emacs-devel@gnu.org; Mon, 15 Oct 2018 22:09:51 -0400 Original-Received: from mail-it1-x12e.google.com ([2607:f8b0:4864:20::12e]:55593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCEnr-0002JZ-CR for emacs-devel@gnu.org; Mon, 15 Oct 2018 22:09:47 -0400 Original-Received: by mail-it1-x12e.google.com with SMTP id c23-v6so31320793itd.5 for ; Mon, 15 Oct 2018 19:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=yR+MfKg6rzha0IZacMFVAAZzpIJEWUFg9ipoUc6D8Ts=; b=Js1d/+4BG/ijUPY5MBMjcRmbAmO6Olr3ZspIAbquKIypKG8rESeo/Mhvqg2N97nzXq IYk19mqvZEa3nnjVIvPVY+DA7ThfWlom/89D27MMVIUhX7J1c/4YgQ9IIj/5AoQGOKnA 9MrxYYFMdFamCBlGlfDnryQxubNJEmJ8M7lT6KLak5MFTCLy7exm7y32s5DiL6YeEjPF JPp2NEFI+HhQMe+e8kbty/iRSv4+G6Z575SjyhGU+PZI8zrPotwtf+w/ykH9kqSh74Ur PX1zbsU2yRlZTnwUYzm1HdoNsB3Mvup4eUBBWfqusYxkcqIvpo0EwRPEnXOSt+MVoGB1 Yurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=yR+MfKg6rzha0IZacMFVAAZzpIJEWUFg9ipoUc6D8Ts=; b=YFlr+/Hb3rxHzLX3UZT30skVYo3mqKDjB/BcpSc6YrBBFpeqmNGlyokl1f85EhELla eJmT5UPWFrILqfbjw0lkOiDxP3nNpBm2XfLvpG2B92vS+FtxYpq7utiMjuRUsT4CFzbs oSxwcVRvKbphAynahtLPgow/zkoi5Y8838wUE1v+At8c9pAxc/dWSpltuvrgFmTSERQv alCCE014AZYHhU0NH+dFm7Y0jWIdAkaS06ux6qvcYs+TvQctRxz1/RX4RkvQ2LnfTc6J fC1qExCDSPH5vke9IsSPpMtPSI9/NT9d+BzrXbUG0KqNX9VPTB5pi+QUOmoJqewXjZuo WhNw== X-Gm-Message-State: ABuFfohKQaK2CDfD8lf+77J9SJ85DkGvIyHo+mpUqJwOj2xKK/jZT6jS HqpCpiSyFnV8DgiiHkUCXCFFnODX X-Google-Smtp-Source: ACcGV63ph0783C3yigMNq/M6w80+PQYpxxZUBeEEME4oVde8vqZQQYJN1ERY5XSIvdn0CD0BBcPRuQ== X-Received: by 2002:a24:fdc4:: with SMTP id m187-v6mr14223067ith.117.1539655786102; Mon, 15 Oct 2018 19:09:46 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id k17-v6sm3535955ioa.72.2018.10.15.19.09.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Oct 2018 19:09:44 -0700 (PDT) In-Reply-To: <6a73c984-002a-f767-6a96-3fb0822489de@luyten.fr> (Pierre-Yves Luyten's message of "Sun, 14 Oct 2018 21:45:55 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230406 Archived-At: Pierre-Yves Luyten writes: >On 10/12/18 11:23 PM, Karl Fogel wrote: >> Would you mind combining this into one patch, since this is conceptually one change, and using the commit message guidelines as given in CONTRIBUTE (see the section "** Commit messages")? > >Hello, here is the change in one single patch, and a few changes to >commit message. Thanks, Pierre. I'll review & test this as soon as possible! Did you produce your patch using 'git format-patch'? We can apply it in either case, but if you produce it that way (and then I use 'git am' to apply), I think that will preserve your commit info and authorship info in the most accurate way possible. The CONTRIBUTE file covers this. Best regards, -Karl