From: Michael Albinus <michael.albinus@gmx.de>
To: John Shahid <jvshahid@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: commit 8147d3c27c breaks grep over tramp
Date: Tue, 09 Apr 2019 17:02:23 +0200 [thread overview]
Message-ID: <871s2bgr28.fsf@gmx.de> (raw)
In-Reply-To: <87imvn5k3k.fsf@gmail.com> (John Shahid's message of "Tue, 09 Apr 2019 10:28:15 -0400")
John Shahid <jvshahid@gmail.com> writes:
> Hi all,
Hi John,
> Looks like commit 8147d3c27c breaks `grep' when ran on a remote host
> using tramp. Previous to the commit I would see the list of grep hits,
> but after this commit there is a command prompt as part of the grep
> hits. This makes the first hit unclickable. I bisected the history to
> find the offending commit and found the following change to be the
> cause:
Will check. My respective commit message was
(tramp-sh-handle-make-process): Simplify.
Maybe this part of the patch could simply be withdrawn. I'm short in
time these days, so I cannot promise it will happen before the weekend,
but who knows ...
> Is anyone else seeing the same thing or is it something with my
> configuration ?
I do :-(
Obviously, tramp-tests.el must be extended, because they've passed
before I've committed the above patch.
> Cheers,
>
> JS
Best regards, Michael.
next prev parent reply other threads:[~2019-04-09 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 14:28 commit 8147d3c27c breaks grep over tramp John Shahid
2019-04-09 15:02 ` Michael Albinus [this message]
2019-04-09 17:38 ` John Shahid
2019-04-13 10:39 ` Michael Albinus
2019-04-14 21:54 ` John Shahid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2bgr28.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=jvshahid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).