From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing Date: Mon, 20 May 2019 13:29:36 +0100 Message-ID: <871s0tl367.fsf@tcd.ie> References: <87ef4uq92p.fsf@tcd.ie> <87d0kdl4yf.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95999"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 14:29:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hShQT-000OpX-OM for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 14:29:57 +0200 Original-Received: from localhost ([127.0.0.1]:34749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hShQS-0002ly-MU for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 08:29:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hShQC-0002kY-FF for emacs-devel@gnu.org; Mon, 20 May 2019 08:29:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hShQB-0004Pn-F2 for emacs-devel@gnu.org; Mon, 20 May 2019 08:29:40 -0400 Original-Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:41696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hShQB-0004Oe-7H for emacs-devel@gnu.org; Mon, 20 May 2019 08:29:39 -0400 Original-Received: by mail-ed1-x541.google.com with SMTP id m4so23595714edd.8 for ; Mon, 20 May 2019 05:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6/hqSmDyMAJvDsC3ZWSAOrbrqKFAuRYPrqqyUs0G/ds=; b=soPFPMZ4kp7w7qGCRBMUNmZnVjshzg1BJ8Dbq8XJtLc880ztxBXrFMh4a+Pr9eDZVR ic347OVmTVOTo4L/mzFAE94NG9eK0tmLwtxhScSCGxMJDr0hRG670YWrbYhI/p9uG3MF 0WlkA4mq/7pRCU2iZXfBHHIq/XA7gQdw2djychVvGOCqLIFcK5fv8lTMiYfzshLqBoxU hNKVsgplgWB0bvmq4MElTos4QrqPaIIs+tvxwMWSKCoUGg+vUjsJklidtbuqcDTUROsG GSm5Q+xMwDY4UoS2inSH3OXn3LMBBc2LTHRCX7NqEAem4Bq7p4B5/oesD8wJooYDhveM JTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6/hqSmDyMAJvDsC3ZWSAOrbrqKFAuRYPrqqyUs0G/ds=; b=jE3rCwZ/AyTz8R7IXLRuejILfqLBmuS4TtDE5sK9fYjGhvw6I3fZV5Xrubp6PHB2z4 u4Y77DbyTme76m6fvSPRbjFJe3kkTJwFfjrv1HmLdGBsuDWnuXPzyKzAwqwWFCERncMj 8a/Oqh0yNHBxtlrIl7kJydq8S4lktBvpF/FSl2OBBQ/RvkHWMhdAf46DoDa+O0XiK/gH 7fyDQPEt7hqBkI7f1xmOGoZaM8WzEerwGoa2pWflWEsNMvG1plZ2cDABA71giAe4kUMv IZmfnApEzhz4BFzT4J1A0n0mIZ6fpRe0rcwjwjn0YLpjLHfi6yDr5EYbmrh1nzjDt4oe tp8A== X-Gm-Message-State: APjAAAXzAITrW+BKnIgIaFDBc/hNxktdJR4d8AvERSvA4frdoDuRmKJa eJu2HdYVaKsmUw9Uw4hnIhQDNmDP+NI= X-Google-Smtp-Source: APXvYqzYh2H4Mfg1Adqrthgb/BsdS5a8CnYna16GEaoHomjeAx5B3Ua4pDBcLVz+O7E213GRKXikbg== X-Received: by 2002:a50:8965:: with SMTP id f34mr74519562edf.296.1558355378104; Mon, 20 May 2019 05:29:38 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id j10sm3115795ejk.49.2019.05.20.05.29.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 05:29:37 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 20 May 2019 13:58:54 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::541 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236788 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> I assume you're referring to the following changes: >> >>> * lisp/gnus/gnus-agent.el (gnus-agent-synchronize-group-flags): >>> Fix indentation. >>> * lisp/gnus/gnus-win.el (gnus-delete-windows-in-gnusey-frames) >>> (gnus-remove-some-windows): Simplify. >> >> If so, I can commit them separately (assuming they're welcome). > > Sorry; I totally confused myself -- I started looking at a different > Gnus diff in the middle of reading your email. :-/ No worries. :) > I think your changes look very reasonable, but I haven't tested. I've given them some light testing, so I'll push them in the next couple of weeks if I don't hear otherwise. Thanks, -- Basil