unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Tassilo Horn <tsdh@gnu.org>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
	"Štěpán Němec" <stepnem@gmail.com>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Auto-resizing of images in image-mode
Date: Wed, 22 Apr 2020 00:28:14 +0300	[thread overview]
Message-ID: <871rogcyvl.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvpnc22tjv.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 20 Apr 2020 09:09:40 -0400")

>> Is it important to maintain compatibility between doc-view and image-mode?
>
> I think it's more important to align the keybinding of those two modes
> than it is to preserve existing key bindings.

's' is too good prefix key to give up on so easily.
It has nice mnemonics:

s h		set height
s w		set width
s r		set rotation
s s		set scale

So if preserving old keybindings is not a requirement,
then doc-view slice commands could be rebound to the prefix 'c'
that has good mnemonics too, where 'c' means 'cut', 'clip'.

@Tassilo: Do you agree this would be a change for the better?

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 8b3d5527f0..a65e06d4d8 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -421,10 +421,10 @@ doc-view-mode-map
     ;; Killing the buffer (and the process)
     (define-key map (kbd "K")         'doc-view-kill-proc)
     ;; Slicing the image
-    (define-key map (kbd "s s")       'doc-view-set-slice)
-    (define-key map (kbd "s m")       'doc-view-set-slice-using-mouse)
-    (define-key map (kbd "s b")       'doc-view-set-slice-from-bounding-box)
-    (define-key map (kbd "s r")       'doc-view-reset-slice)
+    (define-key map (kbd "c s")       'doc-view-set-slice)
+    (define-key map (kbd "c m")       'doc-view-set-slice-using-mouse)
+    (define-key map (kbd "c b")       'doc-view-set-slice-from-bounding-box)
+    (define-key map (kbd "c r")       'doc-view-reset-slice)
     ;; Searching
     (define-key map (kbd "C-s")       'doc-view-search)
     (define-key map (kbd "<find>")    'doc-view-search)



  reply	other threads:[~2020-04-21 21:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 18:13 Auto-resizing of images in image-mode Eli Zaretskii
2020-04-16 21:53 ` Juri Linkov
2020-04-17  6:45   ` Eli Zaretskii
2020-04-18 23:45     ` Juri Linkov
2020-04-19  6:58       ` Štěpán Němec
2020-04-19 23:17         ` Juri Linkov
2020-04-20 10:31           ` Štěpán Němec
2020-04-20 15:29             ` Eli Zaretskii
2020-04-20 23:44             ` Juri Linkov
2020-04-20 13:09           ` Stefan Monnier
2020-04-21 21:28             ` Juri Linkov [this message]
2020-04-22  5:34               ` Tassilo Horn
2020-04-19 12:34       ` Alan Third
2020-04-19 23:18         ` Juri Linkov
2020-04-19 14:06       ` Eli Zaretskii
2020-04-19 23:19         ` Juri Linkov
2020-04-19 23:58           ` Juri Linkov
2020-04-20 14:39             ` Eli Zaretskii
2020-04-20 23:43               ` Juri Linkov
2020-04-21 13:51                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rogcyvl.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stepnem@gmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).