From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Mon, 04 May 2020 23:36:14 +0200 Message-ID: <871rnz8jsh.fsf@web.de> References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> <87368jba7f.fsf@web.de> <87y2qb9tv3.fsf@web.de> <87tv0z9qt2.fsf@web.de> <87bln611vs.fsf@web.de> <87a72p7n4v.fsf@web.de> <87v9ldfvn5.fsf@web.de> <87368fxv8s.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="20311"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 04 23:40:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jViok-0005AH-OG for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 23:40:02 +0200 Original-Received: from localhost ([::1]:50102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVioj-0008ML-IH for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 17:40:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVilO-0007LF-4N for emacs-devel@gnu.org; Mon, 04 May 2020 17:36:34 -0400 Original-Received: from mout.web.de ([212.227.15.3]:50627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVilM-00089i-Qm for emacs-devel@gnu.org; Mon, 04 May 2020 17:36:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588628176; bh=W5GRCbMyMzgL95L8ydJnUSKMWitEMfatt/OuNt/Ymrs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TowrsEqXojOb6tnZmCFlCtfpxd41iX9XiGmYbwgez90yXqCs54ZzjDGZ3igJL+6FM rlz70/1LaVevVYOZzJHwbPn102UANFwS2XTi8+gwqL/wEO6si0qnENsRNGot4CsXfq vPk/cgumTyDn51c0OPlE9fc4eELosB8DoV8886/4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.217.115.241]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mv3Ya-1jE3Jf3Xou-00qyud; Mon, 04 May 2020 23:36:15 +0200 In-Reply-To: <87368fxv8s.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 04 May 2020 14:09:39 -0700") X-Provags-ID: V03:K1:6toksW0YOFsmduRum6zDiiPx+VF8+ESIKOAdsVQwNFDBYSYV0Zn v+Q5w5ny9Y071228+Il05sOIL54Ae7zD3YIpV1wACPGwT114EJ4yREe2hPYlReACQ8rT4Pu gBsq/+gYnu/ZMalN2xnYr0CWnlccPt5gnv4WUjwbURHmMj59NlGhWMjB0UmY81IXbpg4jAW FCtwvFT292S5DgOSVI6WQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:4/y/9sPkFGY=:9nO03WFYDNyR6ujvIqFQl7 +dX+l3dfNV1Ke3HuSNkm3p2TjAbZBZyNmaBeYiEUMJvBTDkFlzoATnuFa1t4cj7kP3nbUt6AU tWgDdShxYC26M7Au+yZ9xdVes4OqCwf1PWLAAj0eusq11o+Wu7xz3OZsA3z3xpMrUaeB0JtvH T2cqSPziT1k/7X663eJUrRDSP9XTVuBimo6osWo+58brL1YcxVZiDBUV/4IXjpd3Yf3js6efQ QwgjWXs/Dw6ijoRth7qXGdcNbGRVjkiarwqrQUNCAltysu/PmGIv9WgXcho+io0li3XzYjkmw EJnqFC/r8BUMW/TZe0JHijZuCh9TaICU7vIYgJW4lEMkXUZDl/vFsI1+SpUpOGih5CEhOQyyO 14INq2+oqkXEaTsR36bEnPSzj7237snUiCEt+VgC4oMX+gEHyMki3IVEQLTu2X8N3VGT8YJv2 k9YsehLeeSO93OmO0wc9tZmP949HSkWpfdCtVNVkFRl96RCzUk8FkrCd6CXh+fw87MGxmeuHu nfQzhCJjUMQQcsiZ5xdG6aK32k2mRo/DLcTpM+5TAlTg8vlgGdtzF5gv9k95hXi4tZqs+MM6A 5DqqB42GIG1KrivtIIJCI/nQJZimzW2Jwd8YuIEJNDMiMlclys3BjhyCnXILwQa6RR0dUWpa4 cMEdde/xL8LHkdQKSadcA24Xdg3jHjZB/xjVe8uwPTSHkA7q6rW1yY1aY9Ydx9p3xs1PLxX5M 3z5++WoyC68ZMHZI3xS6w6Tj+Yj+qwoNYi8v2f2UmBQNx7/FOj3Doq5xWu24LP+zPRaM54v8 Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 17:36:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248912 Archived-At: Eric Abrahamsen writes: > ;; With modification hooks uninhibited (ie, reverting Michael's commit). > (benchmark-run 100 (my-save-registry)) -> (1028.64836554 2801 > 537.1068782020001) > (benchmark-run 100 (my-save-ebdb)) -> (51.585404029 134 20.779424303000003) > > ;; With modification hooks inhibited (Emacs master). > (benchmark-run 100 (my-save-registry)) -> (989.206686569 2800 526.325465032) > (benchmark-run 100 (my-save-ebdb)) -> (63.946958194 127 23.392065172000002) `my-save-ebdb' is slower with modification hooks inhibited? Anyway, the time differences are quite small. Michael.