From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: Un-deprecating oset Date: Tue, 12 May 2020 16:47:16 -0500 Message-ID: <871rnohlln.fsf@alphapapa.net> References: <87eery1xhe.fsf@bernoul.li> <87a72d42h2.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="15767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 23:47:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYckk-0003lI-As for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 23:47:54 +0200 Original-Received: from localhost ([::1]:45120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYckj-0005vT-DI for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 17:47:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYckH-0005WN-6f for emacs-devel@gnu.org; Tue, 12 May 2020 17:47:25 -0400 Original-Received: from ciao.gmane.io ([159.69.161.202]:58512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYckF-0005Ez-R2 for emacs-devel@gnu.org; Tue, 12 May 2020 17:47:24 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jYckE-00032H-7D for emacs-devel@gnu.org; Tue, 12 May 2020 23:47:22 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=159.69.161.202; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 15:14:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250053 Archived-At: Jonas Bernoulli writes: > Well, it seems nobody else (who has noticed so far) shares my opinion > (enough to comment here). I'll go replace my uses of `oset' now. Since you asked (sort of): If I had to vote, I'd vote in favor of keeping oset rather than deprecating it. I generally like using setf, but (setf (oref ...)) feels unnecessarily verbose compared to (oset ...). But if oset didn't already exist, I'm not sure I'd favor adding it. For myself, if Stefan wants to deprecate it, I can live with that. Of course, you've written orders of magnitude more EIEIO-using code than I have (I wouldn't be surprised if you've written more than anyone), so your perspective is different from mine. :)