From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: POLL: make C-x o transient Date: Wed, 03 Feb 2021 19:20:05 +0200 Organization: LINKOV.NET Message-ID: <871rdxqw9e.fsf@mail.linkov.net> References: <2EFBBE54-62F4-4373-82D6-DC8750B648BA@kuaishou.com> <8735yhpou7.fsf@iki.fi> <87r1lz1zfg.fsf@mail.linkov.net> <87y2g645l8.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4956"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: condy , Zhiwei Chen , emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 03 19:17:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7MiR-0001BV-83 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Feb 2021 19:17:23 +0100 Original-Received: from localhost ([::1]:57770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7MiQ-0007WN-8N for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Feb 2021 13:17:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7MED-0004iv-Id for emacs-devel@gnu.org; Wed, 03 Feb 2021 12:46:09 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:39255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7MEB-0007jK-5B for emacs-devel@gnu.org; Wed, 03 Feb 2021 12:46:08 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5AFAD1BF206; Wed, 3 Feb 2021 17:45:58 +0000 (UTC) In-Reply-To: <87y2g645l8.fsf@melete.silentflame.com> (Sean Whitton's message of "Tue, 02 Feb 2021 12:44:51 -0700") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263820 Archived-At: >> In this case it's easy to implement it as a minor mode that uses hooks, >> e.g. last-char-repeatable-mode added to repeat.el. >> >> This could be like delete-selection-mode that by default >> puts a special property on symbols of affected commands. > > I think this is the best way to implement this. People who don't want > to accept getting into transient states where not every self-insert key > is self-inserting can turn the mode off entirely (and maybe bind 'repeat > to C-z or something, which is what I do), and people who haven't had > problems with that can turn it on once and have it work all over. As Gregory noted, it's not clear which keys to use in every case: for 'C-x o' it makes sense to use the shifted version "O" too, for 'M-g n' also to use the opposite key "p". It's possible to solve this by attaching own transient map to each repeatable command like: (put 'other-window 'repeat-map 'other-window-repeat-map) (defvar other-window-repeat-map (let ((map (make-sparse-keymap))) (define-key map "o" 'other-window) (define-key map "O" (lambda () (interactive) (other-window -1))) map) "Keymap to navigate windows.") (put 'next-error 'repeat-map 'next-error-repeat-map) (put 'previous-error 'repeat-map 'next-error-repeat-map) (defvar next-error-repeat-map (let ((map (make-sparse-keymap))) (define-key map "n" 'next-error) (define-key map "p" 'previous-error) map) "Keymap to navigate errors.")