From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Mon, 15 Mar 2021 10:00:42 +0100 Message-ID: <871rcgeqpx.fsf@gmx.de> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87a6r5efwm.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25159"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 15 10:03:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLj8R-0006SR-BM for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 10:03:35 +0100 Original-Received: from localhost ([::1]:44694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLj8Q-0003EG-8v for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 05:03:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLj5q-00026B-Uu for emacs-devel@gnu.org; Mon, 15 Mar 2021 05:00:54 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:47363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLj5n-0008MJ-Jf for emacs-devel@gnu.org; Mon, 15 Mar 2021 05:00:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1615798844; bh=O9Ytsa/vofnJvOL8neq41TRy+nHyZBf5eAKGZV/9HQ8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CLw9FOHR2kEs5n3LRxfzaHg3n1mKv7R2lBlkHRBp6IW6CsCIARAght6UbMjiS+hVB /jGwzbXr1VSQxJ9SYxHp54gAfNmJxYyjMe8akAfZH2k+3Sf3q7B5eeYW2KVZ4b2h7s GFWgPT+0uJwmYJnR3sD9jk1rszQ7i8ctJexSgnXc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([178.20.90.8]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MRTRH-1l7FAf1ylB-00NPTo; Mon, 15 Mar 2021 10:00:44 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 14 Mar 2021 16:30:01 -0400") X-Provags-ID: V03:K1:6DOVJEC9Rh5r4998WXKitEi7ZcItZwixfpZY8RvNqoVJdxUPfBN XsJ2kGmpt0+TL/gQRmpLn17jPrh73upRdoBD9PTDQv+e5Xv5a+F+HOour8dt64+NxMcpu83 hyJQw2HzBodTM/16p5z1vCVQ6auL3gel8QAu62vHyaLbsrHAK/SDztp+UqTpBGhuA0G3LEm e/mHGdRMsZ+qZuajfr2kw== X-UI-Out-Filterresults: notjunk:1;V03:K0:7+UmMMPwK3A=:VXcQZaBYvd1dACSMBbPRe+ Rqki5H/SA0dGFHKuNKDnh1kSbnLry53clmKGAo5IA00wyKRajZafY0XIZm/jUAz28E5UjHKz9 D9pJKvkgYgN25IDcOtoqD6u5Mp9eKW3VRslQuZNdmjPks3mfkcjSQN/IODyTtKcq9KE2kqjCk 9+YGVjrg/8w3xctLC8r/tUkeVcbAu1inWFpWbEQ3fh8Y6wgAM3oYOWvBlv7mNVi46cFOx7U/2 raf2XjQ1BcSQwHepHg/EjoX348qC8vw3xIRUg/lk2bBBKLI3TZ2r26Wa1Krpz5VaWu1WVFwwB /vNc+OImabBXzxzPCrgEqAyBtih+JlgX3hsZ1VtX92HruvJv+FJIASSwIflshSPd4c91DxHcC u9tYVAbLm6+PDnmoJdjJLv0GAbh4amDVSwpWfN5W1QeuSoFohyWFRLB7ktFi6Uh7yP+JBVMEt eODMIaMSzy349XRD6k4aVCSG+01xhpTTcmT8BUJJdpYMOm625uOKKREAIG1T84GuSypG3gEmB yq13GUbB8AeyxzuU8ffk07TtZ8nDNB1YaO5ekZP7waMZzw8YZG5RNi6qtoI3MNhCJIs1/IfmQ QoYVsN1EKZntO2a4lojbZGtpXArhRVOC4wG/V6jtjWaK2Rba9ou+zPGDLJiRqgQwmz9UcmDs8 TRcpm4BPDdt8r4dW9Ty5Wf4sTMQV4L2XXXBB3xfiqTuPiby2XarLllRhE2s3OCRHE4/mAQTTP 0SKmIqf56db9UR+UQF4vk+0b4tPJrn4U39QHpuzsh6wBxLUn1IhaLpJ1iCyQCgpEvPiSvD/o Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266476 Archived-At: Stefan Monnier writes: Hi Stefan, >> Of course, we can live w/o that predicate. We did until now. But OTOH, >> it doesn't hurt to check this, that's why this kind of check has been >> added to Emacs. > > What I mean is that this is a predicate which should be most useful to > those who never use `tramp-crypt` (e.g. because `encfs` is not > installed), so only activating it when `tramp-crypt` is loaded makes it > *much* less useful. I don't want to activate the predicate before tramp-crypt.el is loaded, because this would counteract the idea to keep tramp-crypt related code in tramp-crypt.el. > This predicate is only useful for those users who don't have > `encfs` installed. Which proportion of those users do you think has > `tramp-crypt` loaded in their Emacs session? My guess is that this is > pretty close to 0%. Well, it is also useful for users who have tried tramp-crypt-add-directory, and see afterwards that it doesn't work for them. But yes, this is a small number of users. OTOH, it doesn't hurt. I don't see any price we have to pay for this predicate, in terms of performance or whatsoever. People who don't use tramp-crypt.el are not affected in any way. And I have extended the predicate just now to be more useful for the other command in tramp-crypt.el, tramp-crypt-remove-directory. > Stefan Best regards, Michael.