From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 18:18:44 +0000 Message-ID: <871rc14w3f.fsf@tcd.ie> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <878s6aaq0x.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Michael Albinus , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 19:27:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPrBZ-000AMO-NM for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 19:27:53 +0100 Original-Received: from localhost ([::1]:56884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPrBY-0006Lb-Ho for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 14:27:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPr2z-00030o-IG for emacs-devel@gnu.org; Fri, 26 Mar 2021 14:19:06 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:55043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPr2n-0004jI-SN for emacs-devel@gnu.org; Fri, 26 Mar 2021 14:19:00 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id k128so3435134wmk.4 for ; Fri, 26 Mar 2021 11:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b46Ww/GZTED/kXdcXgOWlefLtMF+4o02zvbL0jknDMk=; b=e0okEunjdJR+x9+AaF4QbCAW4eMUkzzEn73t6gMk+LNHJHMOirzjLi4pCZNqvssW6g 0PE0qbytFfLhlafRBiutV84G1OLCLYyEEpF72i95G/Vwq6zeqfM/Kmihjg8yQPrqG/sm jqTIuCG4Slakzo6nVkcOGlB5ZZ6cDVl49UgoVrmAk70BhZm+Pw+ERFIxCeKgOTWFDQlO leg0l/DTWiuk2WzajOK0tGkYQaXJMG6HujQR1gjX18KAfSWmzVwDv2kPmF2HzHaK1z8N JJifYGcCHzyEADaw2W5TkAc8nvFjWksAgq7maQmDcabXYfwswewSjzPrND3+OhBu+DoL +dpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b46Ww/GZTED/kXdcXgOWlefLtMF+4o02zvbL0jknDMk=; b=dAJzSccSd/IAt+JsyCXgB4E7bMtomoEdmOnnFKkSeDlNFEWNZBDNRnSguQJkf61Y8V u5KY0gDRG0oTk53vvmkYndUuakyF8Hv7Pk6PMzKZ1BAue96agRY4pHBZAuyA7ln2odgT 4N8staAfzE1BqqNugiviF/Fnp+eWbdIrP9Dvdn0zJbS6TTLejGIY2tvaH/beuyg40+Tr ZwqvZJOiHHFgwYlEfZyuJLSWUeq+f8htGpkui4VPMNlCZxNN/vSjnG2n7CxwfiOIGjwQ 6Ssdk4fs8arCZGxmRvw3kHkKPEaXiDILG5JdHXeN0+oxezVJMPmBvr6WPs7mHr+Qq5Ed 80kw== X-Gm-Message-State: AOAM530gPYlpzIILswQqevemQkeYilWuzpQhuGf8judszDOGPZhM224x vkgdV5wFkWg/vs2au2BkuZwWXg== X-Google-Smtp-Source: ABdhPJwfNZy54sgIlHGvt30HTnrjqxAZdPii+iZJdvaBnhSyzSxOFfgcqVwIusl4eD+bO7oLDjp3Nw== X-Received: by 2002:a05:600c:4f8e:: with SMTP id n14mr14651577wmq.166.1616782726999; Fri, 26 Mar 2021 11:18:46 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id o8sm3383532wmr.28.2021.03.26.11.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:18:46 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 26 Mar 2021 12:32:32 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=contovob@tcd.ie; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267082 Archived-At: Stefan Monnier writes: >>>> What's the performance impact here? This is going to be called a whole >>>> bunch of times when the user hits TAB... >>> It should be OK to do the condition-case wrapping around the loop rather >>> than within it, so the performance impact should be negligible. >> "Around the loop" means "around completing-read", > > Not necessarily, e.g. > @@ -1998,11 +1999,12 @@ read-extended-command > "M-X " > "M-x ")) > (lambda (string pred action) > - (if (and suggest-key-bindings (eq action 'metadata)) > - '(metadata > - (affixation-function . read-extended-command--affixation) > - (category . command)) > - (complete-with-action action obarray string pred))) > + (with-demoted-errors "Completion error: %S" > + (if (and suggest-key-bindings (eq action 'metadata)) > + '(metadata > + (affixation-function . read-extended-command--affixation) > + (category . command)) > + (complete-with-action action obarray string pred)))) Oops, indeed. But as we've agreed elsewhere, leaving the completion table empty is not ideal. -- Basil