From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Thu, 06 May 2021 10:49:15 +0200 Message-ID: <871rak2qno.fsf@gnus.org> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 06 10:50:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZiX-0007hz-HJ for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 10:50:45 +0200 Original-Received: from localhost ([::1]:55132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZiW-0008PW-J0 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 04:50:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZhE-0007BB-Sm for emacs-devel@gnu.org; Thu, 06 May 2021 04:49:26 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:35052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZhB-0008OV-8k for emacs-devel@gnu.org; Thu, 06 May 2021 04:49:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c3ttB5DmZk+KpIYt1sL4hxVBvvlhkaYfdN5/ZIf3kn0=; b=AKziB6wR1qFCZxv1s/EeCYHE8p aa7SmcGMLNhENPfoZiKYPe46JY3K/BdUJpk/YygOlWQYoYDWRJpvYy3cyOnz1+yg44fFdARdNOJBU w1b3UsyYsG5VCe/ZxB2WooxtUU8TnRSJhPhDoLkHzO8tsaHHVeQG1uTLZBldI3qjS47Q=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZh5-00054Q-TW; Thu, 06 May 2021 10:49:18 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXYzs+OjW41OT/R PD7///+EBMjBAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFBggnImZgUgQAAAGlSURBVDjLlVIBdusw CAP3AgZfIJALxOH+d5swXtfuvW3/0zaOKyOBMNG/Redve/wYHzq4NjtaPiSh3t8AzcMAQGSdXtgE OSI42+gA5/FCJYnS0TgTvgBQMwlTF8b3W2H/GYx8Tq4k+/OwSMe33uj51qm5nxGB7QPLjJkNux/U TG3KhBEJPAAIjdWcu5nYzriQC8C1J19GATMWlaRGPjZYyvuVRh4S8YgNgBDilu7zRQQRlJH2ubgO NdoMjgXaez6GjEyDBpZNWn3Yp9Z7wAtSjR1jDtTK7p66Ccz8WxYgNfFcRvU0ZURlwJuVMZ7Nbipk 93UNEJ6B1b7kFQBY1MWiL6+2AY3cY4rqAniWJaC/yTRu9yytx2Ou/mcBMtEo0sIij/inhv8QhIHf Jn4x1/BR7uVWwCznPUcLS6z5uJ0cl6EAHKlRcwGu66g8zpnmg6ovjR/F37d9eYX7pqsqjNlUVn3L 9hzsE5AFQK4LIfG1QWBazRvRL50f3FvNPMuVcetyIIGjObivOLnrjBvNnJEZDYAngOuVGhjoeW+q BCK2ODw/f+v8A+yNXZXEFav9AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTA2VDA4OjM5OjM0 KzAwOjAwM5tbOgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0wNlQwODozOTozNCswMDowMELG 44YAAAAASUVORK5CYII= X-Now-Playing: Games's _That We Can Play_: "Midi Drift" In-Reply-To: <878s4tq8e6.fsf@red-bean.com> (Karl Fogel's message of "Wed, 05 May 2021 14:37:37 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268954 Archived-At: Karl Fogel writes: > Giving people the ability to prevent the bad thing from happening > is not the same as giving them ability to recover if the bad thing > happens. It's not the same -- giving them the ability to recover is better. :-) We're teaching users to hit "y" after a whole bunch of commands, and the "y" becomes automatic. > Also, implementing undo functionality would open up a whole lot of > questions. It does, but a thing like this doesn't have to be 100% to be useful. Every new thing that's made undoable is progress. > Well, there is the etc/NEWS entry, but still I kind of agree with you. > I would have chosen the default-to-true route, though Eli's preference > for the other way is perfectly reasonable; this isn't a One Right Way > situation IMHO. There isn't, but if it's worth having a query, then that query is worth the most to new users -- more experienced users can then choose to switch it off or on. Adding this option, but defaulting it to nil doesn't add much value, in my opinion. Anybody can add a prompter to any command by just doing: (advice-add 'bookmark-bmenu-execute-deletions :before (lambda () (unless (y-or-n-p "Really execute?") (error "Nope")))) Perhaps we should just make a convenience function for people to add prompters to any command they want to... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no