From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Speed up project-kill-buffers Date: Sat, 08 May 2021 12:30:06 +0000 Message-ID: <871rahs90x.fsf@posteo.net> References: <87mttcgnke.fsf@posteo.net> <871raoezl0.fsf@posteo.net> <86r1ihig9p.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 14:31:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfM7I-0004S0-JJ for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 14:31:32 +0200 Original-Received: from localhost ([::1]:35930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfM7H-0005zF-GN for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 08:31:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfM63-0004yO-MV for emacs-devel@gnu.org; Sat, 08 May 2021 08:30:15 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:51923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfM61-0001QK-Df for emacs-devel@gnu.org; Sat, 08 May 2021 08:30:15 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E21202400FC for ; Sat, 8 May 2021 14:30:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1620477007; bh=cEp0z4bCuAsufj4fXlm+13SVgwNSYbHW/fXapPS5amk=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=WFocWtcrOqTG8mRHIwINAuPoSttp0OK3UL0F2TRdGg37yve9QiD8ca4ewp7FASM/9 OjJWOuQzOZ4BUOYMoo7nxLvBmMpL+Gj8MYYsJ3Q20/78A3AbbZSHNrhDIAkOUlxKgN iU3FSZ/muBpLgjFsAkQc2uPFjilJ9qSNr/Fp/yaKfOslCGnOs+FKFogN3CrYt8/QBY qOOSjik9zqP4C6bgM7wmpvc6AIOjLGrrw/lsfH3WbnSdkdeSstvRRSKwpay+cPEYYG /UKZ9/NAzhW6pxVvI5UG0BB7ifXVELa30kwqGSnrJERaAIaUba9JOQYOnxIc39eCuG hiqCJhLCAUskw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FcmqL5xBXz6tmF; Sat, 8 May 2021 14:30:06 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <86r1ihig9p.fsf@stephe-leake.org> (Stephen Leake's message of "Sat, 08 May 2021 05:03:46 -0700") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269043 Archived-At: Stephen Leake writes: > Stefan Monnier writes: > >>> I didn't know about that function! Just tried it out and it seems that >>> the patch below is even faster, as project-current does not have to be >>> invoked for every buffer, remote or not. >> >> I think it might misbehave if you have projects nested in the directory >> of other projects, tho. > > There are also projects that do not have a single root; an Emacs elisp > project (which has load-path as roots), any project with dependent > external libraries. > > You can check (member file (project-files prj)), but that's about the > same as your first patch. So maybe something like (let ((root (project-root proj)) (extr (project-external-roots proj))) (member file (project-files proj (cons root extr)))) ? -- Philip K.