From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Date: Sun, 09 May 2021 20:59:45 +0300 Organization: LINKOV.NET Message-ID: <871rafrdny.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 20:10:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfnsb-00083Y-Qb for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 20:10:13 +0200 Original-Received: from localhost ([::1]:51026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfnsa-0003Ht-RZ for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 14:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfns3-0002aX-38 for emacs-devel@gnu.org; Sun, 09 May 2021 14:09:39 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:58317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfns0-0002Wp-Ej for emacs-devel@gnu.org; Sun, 09 May 2021 14:09:38 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 59803240003; Sun, 9 May 2021 18:09:29 +0000 (UTC) In-Reply-To: <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> (Daniel Mendler's message of "Sat, 8 May 2021 11:10:59 +0200") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269086 Archived-At: >> I attached the current set of patches. The last patch >> "0005-group-function-Implement-generalized-action-argument.patch" >> implements the generalized action argument. The other patches (1-4) do >> not differ from the previously sent patches. I send them for completeness. Thanks, I tested it with mule--ucs-names-group, and everything works well. > Correction to the lastest patch. The `minibuffer--group-by` function > should actually be written as follows: > > (defun minibuffer--group-by (group-fun elems) > "Group ELEMS by GROUP-FUN." > (let ((groups)) > (dolist (cand elems) > (let* ((key (funcall group-fun 'title cand)) > (group (assoc key groups))) > (if group > (setcdr group (cons cand (cdr group))) > (push (list key cand) groups)))) > ;; FIXME: Is thread-last allowed in minibuffer.el? subr-x is not preloaded, but since thread-last is a macro maybe it's possible to expand it during compilation: (eval-when-compile (require 'subr-x)) > (setq groups (nreverse groups) > groups (mapc (lambda (x) > (setcdr x (nreverse (cdr x)))) > groups) > groups (funcall group-fun 'sort groups) > groups (mapcar #'cdr groups)) > (apply #'nconc groups))) Or maybe simply `mapcan`.