From: Juri Linkov <juri@linkov.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: Gregory Heytings <gregory@heytings.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4)
Date: Sun, 09 May 2021 20:59:45 +0300 [thread overview]
Message-ID: <871rafrdny.fsf@mail.linkov.net> (raw)
In-Reply-To: <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> (Daniel Mendler's message of "Sat, 8 May 2021 11:10:59 +0200")
>> I attached the current set of patches. The last patch
>> "0005-group-function-Implement-generalized-action-argument.patch"
>> implements the generalized action argument. The other patches (1-4) do
>> not differ from the previously sent patches. I send them for completeness.
Thanks, I tested it with mule--ucs-names-group, and everything works well.
> Correction to the lastest patch. The `minibuffer--group-by` function
> should actually be written as follows:
>
> (defun minibuffer--group-by (group-fun elems)
> "Group ELEMS by GROUP-FUN."
> (let ((groups))
> (dolist (cand elems)
> (let* ((key (funcall group-fun 'title cand))
> (group (assoc key groups)))
> (if group
> (setcdr group (cons cand (cdr group)))
> (push (list key cand) groups))))
> ;; FIXME: Is thread-last allowed in minibuffer.el?
subr-x is not preloaded, but since thread-last is a macro maybe it's possible
to expand it during compilation: (eval-when-compile (require 'subr-x))
> (setq groups (nreverse groups)
> groups (mapc (lambda (x)
> (setcdr x (nreverse (cdr x))))
> groups)
> groups (funcall group-fun 'sort groups)
> groups (mapcar #'cdr groups))
> (apply #'nconc groups)))
Or maybe simply `mapcan`.
next prev parent reply other threads:[~2021-05-09 17:59 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 13:32 [PATCH] `completing-read`: Add `group-function` support to completion metadata Daniel Mendler
2021-04-25 19:35 ` Dmitry Gutov
2021-04-25 19:47 ` Daniel Mendler
2021-04-25 21:50 ` Dmitry Gutov
2021-04-25 22:10 ` Daniel Mendler
2021-04-25 22:40 ` Dmitry Gutov
2021-04-25 22:58 ` Daniel Mendler
2021-04-26 4:51 ` Protesilaos Stavrou
2021-04-27 16:53 ` Juri Linkov
2021-04-28 6:18 ` Protesilaos Stavrou
2021-04-25 23:33 ` Stefan Monnier
2021-04-26 10:01 ` Daniel Mendler
2021-04-26 13:50 ` Stefan Monnier
2021-04-27 1:46 ` Dmitry Gutov
2021-04-27 1:59 ` tumashu
2021-04-27 2:45 ` Daniel Mendler
2021-04-27 15:47 ` Dmitry Gutov
2021-04-27 3:41 ` Stefan Monnier
2021-04-28 0:08 ` Dmitry Gutov
2021-04-28 3:21 ` Stefan Monnier
2021-04-25 19:38 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Daniel Mendler
2021-04-25 20:45 ` Juri Linkov
2021-04-25 21:26 ` Daniel Mendler
2021-04-29 16:20 ` Juri Linkov
2021-04-29 16:52 ` Daniel Mendler
2021-04-29 17:07 ` Stefan Monnier
2021-04-29 17:13 ` Daniel Mendler
2021-04-29 22:54 ` Juri Linkov
2021-04-29 23:55 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Daniel Mendler
2021-04-30 9:00 ` Daniel Mendler
2021-04-30 17:01 ` Juri Linkov
2021-04-30 18:11 ` Daniel Mendler
2021-04-30 18:30 ` Daniel Mendler
2021-05-01 19:57 ` Juri Linkov
2021-05-02 0:43 ` Daniel Mendler
2021-05-02 7:07 ` Eli Zaretskii
2021-05-02 11:01 ` Daniel Mendler
2021-04-30 16:51 ` Juri Linkov
2021-04-30 18:13 ` Daniel Mendler
2021-05-01 19:54 ` Juri Linkov
2021-05-02 0:32 ` Daniel Mendler
2021-05-02 21:38 ` Juri Linkov
2021-05-07 17:03 ` Juri Linkov
2021-05-07 17:55 ` Daniel Mendler
2021-05-08 6:24 ` Daniel Mendler
2021-05-08 8:45 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Daniel Mendler
2021-05-08 9:10 ` Daniel Mendler
2021-05-09 17:59 ` Juri Linkov [this message]
2021-05-09 18:50 ` Daniel Mendler
2021-05-09 18:56 ` Stefan Monnier
2021-05-09 19:11 ` Daniel Mendler
2021-05-10 20:47 ` Juri Linkov
2021-05-11 7:51 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 5) Daniel Mendler
2021-05-11 17:59 ` Juri Linkov
2021-05-08 13:15 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Stefan Monnier
2021-05-09 18:05 ` Juri Linkov
2021-05-09 18:37 ` Eli Zaretskii
2021-05-11 18:06 ` Juri Linkov
2021-05-11 18:44 ` Eli Zaretskii
2021-05-11 18:58 ` Daniel Mendler
2021-05-11 19:22 ` Eli Zaretskii
2021-05-11 19:46 ` Daniel Mendler
2021-05-11 19:59 ` Eli Zaretskii
2021-05-11 20:30 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 6) Daniel Mendler
2021-05-13 10:32 ` Eli Zaretskii
2021-05-13 11:45 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7) Daniel Mendler
2021-05-20 9:39 ` Daniel Mendler
2021-05-20 17:53 ` Juri Linkov
2021-05-20 18:51 ` Daniel Mendler
2021-04-29 17:09 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Dmitry Gutov
2021-04-29 17:16 ` Daniel Mendler
2021-04-29 17:55 ` Dmitry Gutov
2021-04-29 18:31 ` [External] : " Drew Adams
2021-04-29 20:25 ` Dmitry Gutov
2021-04-29 22:15 ` Drew Adams
2021-04-29 22:28 ` Dmitry Gutov
2021-04-29 23:31 ` Drew Adams
2021-04-29 19:21 ` Daniel Mendler
2021-05-02 14:29 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 3) Daniel Mendler
2021-05-02 21:49 ` Juri Linkov
2021-05-03 14:40 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rafrdny.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).