From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Thu, 27 May 2021 00:45:17 +0300 Organization: LINKOV.NET Message-ID: <871r9t2lsy.fsf@mail.linkov.net> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Daniel Mendler , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca, Dmitry Gutov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 27 00:10:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1jJ-0005qT-Aj for ged-emacs-devel@m.gmane-mx.org; Thu, 27 May 2021 00:10:21 +0200 Original-Received: from localhost ([::1]:35430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm1jI-0008GD-7b for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 18:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm1iX-0007Zo-Ia for emacs-devel@gnu.org; Wed, 26 May 2021 18:09:33 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm1iU-00036v-FM for emacs-devel@gnu.org; Wed, 26 May 2021 18:09:33 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3D7E9C0002; Wed, 26 May 2021 22:09:22 +0000 (UTC) In-Reply-To: <87y2c24lww.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 25 May 2021 23:37:43 +0300") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269931 Archived-At: >> Sure it's not beautiful, but it's an improvement to annotation-function. >> If affixation-function were a function of a single completion, it would >> be fine. For a hint at a good design, look at the language server >> protocol. It returns a large list of completions, and then you can >> "resolve" a completion to get many more of its properties. So >> resolution-function is an option. > > resolution-function sounds good. Maybe this is not the most > suitable comparison but since you mentioned the word "resolve" > that evoked by association: resolver functions used in GraphQL. Then instead of such ad-hoc meta functions: :annotation-function (lambda (str) (if (fboundp (intern-soft str)) " ")) :company-kind #'elisp--company-kind :company-doc-buffer #'elisp--company-doc-buffer :company-docsig #'elisp--company-doc-string :company-location #'elisp--company-location)) we could have one function :resolution-function (lambda (str fields) (mapcar (lambda (field) (pcase field ('suffix (if (fboundp (intern-soft str)) " ")) ('kind (elisp--company-kind str)) ('doc-buffer (elisp--company-doc-buffer str)) ('docsig (elisp--company-doc-string str)) ('location (elisp--company-location str)))) fields)) called with e.g. (funcall (completion-metadata-get md 'resolution-function) '(prefix suffix location kind)) When 'prefix' is not implemented by the backend, it just returns 'nil'.