From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: New Context Menu Date: Fri, 20 Aug 2021 19:49:03 +0300 Organization: LINKOV.NET Message-ID: <871r6odq3s.fsf@mail.linkov.net> References: <20210818120834.i3orh535tb2enpos.ref@Ergus> <20210818120834.i3orh535tb2enpos@Ergus> <87r1epzznt.fsf@mail.linkov.net> <83zgtd2762.fsf@gnu.org> <87fsv4io41.fsf@mail.linkov.net> <838s0w1hiz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: spacibba@aol.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 20 18:53:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH7lO-0003Ca-MR for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Aug 2021 18:53:02 +0200 Original-Received: from localhost ([::1]:45620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH7lN-0005jc-DS for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Aug 2021 12:53:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH7kb-0003gc-U7 for emacs-devel@gnu.org; Fri, 20 Aug 2021 12:52:14 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:50299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH7ka-0002fX-9a; Fri, 20 Aug 2021 12:52:13 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 12B384000A; Fri, 20 Aug 2021 16:52:08 +0000 (UTC) In-Reply-To: <838s0w1hiz.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Aug 2021 14:29:08 +0300") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272734 Archived-At: >> >> But please note that currently when you select a menu item >> >> using the keyboard, many commands will fail with >> >> >> >> (error "Command must be bound to an event with parameters") >> > >> > Those commands should ideally be fixed to not signal such errors, >> > because that's not good UI on TTY frames. Commands that cannot be >> > fixed shouldn't appear in the context menus popped on TTY frames to >> > begin with. >> >> What would be the best strategy for fixing these commands? This error >> is signaled for all commands that have (interactive "e"). Then such >> interactive spec should be removed from all commands used in the menu? > > I guess so. Why does it make sense for commands invoked from the > menus to have the "e" interactive spec? There are too many commands that have the "e" interactive spec. It would be much simpler not to signal an error for them, but produce a fake event where the clicked position is set to the position of point.