unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch] Draw and scribble notes in GNU Emacs
Date: Thu, 09 Sep 2021 16:33:08 +0800	[thread overview]
Message-ID: <871r5yno6z.fsf@yahoo.com> (raw)
In-Reply-To: <CADm7Y4nWYswRR-uk5ACZ5YTvC94mGX-ZRRUOm=hB8LkOLEZNSg@mail.gmail.com> (Anand Tamariya's message of "Thu, 9 Sep 2021 13:24:44 +0530")

Anand Tamariya <atamariya@gmail.com> writes:

> Code: https://gitlab.com/atamariya/emacs/-/blob/dev/lisp/svg.el

Good work, but it appears to be comprised solely of modifications to
svg.el.  Is there any particular reason it cannot be separated from the
rest of svg.el, which is geared towards programmatic creation of images,
as opposed to providing a paint program?

  . ;; ewp functions copied from https://github.com/larsmagne/ewp/blob/master/ewp.el
  . (defun ewp-crop-image (&optional square)
  . (defun ewp-crop-image-update (area data size type)
  . (defun ewp-crop-image-1 (svg &optional square image-width image-height)
  . (defun ewp-find-corner (area pos corners)
  . (defun ewp-content-type (image)
  . (defun ewp--image-type ()

It would be good to prefix the names of these functions with something
other than "ewp", because they could conflict with the functions present
in ewp.

Further, I don't believe ewp has undergone copyright assignment to the
FSF.  If the code is to be included in Emacs, that will likely have to
be solved first.



  reply	other threads:[~2021-09-09  8:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  7:54 [Patch] Draw and scribble notes in GNU Emacs Anand Tamariya
2021-09-09  8:33 ` Po Lu [this message]
2021-09-09 12:00   ` Eli Zaretskii
2021-09-09 12:23     ` Po Lu
2021-09-09 14:51       ` Lars Ingebrigtsen
2021-09-10 21:45         ` dalanicolai
2021-09-13  5:32           ` Anand Tamariya
2021-09-13  5:15   ` Anand Tamariya
2021-09-09 14:50 ` Lars Ingebrigtsen
2021-09-13  5:36   ` Anand Tamariya
2021-09-13  8:25     ` Lars Ingebrigtsen
2021-09-13  8:31       ` Anand Tamariya
2021-09-13  8:47         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r5yno6z.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=atamariya@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).