From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Tue, 14 Sep 2021 13:54:01 +0200 Message-ID: <871r5rwexy.fsf@gnus.org> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> <871r5semh0.fsf@gnus.org> <87v934tgi0.fsf@gmail.com> <87lf3zwgpi.fsf@gnus.org> <83fsu7crbo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29156"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: kfogel@red-bean.com, stefan@marxist.se, pwr@bydasein.com, orontee@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 14 13:56:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ72n-0007QP-FH for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Sep 2021 13:56:09 +0200 Original-Received: from localhost ([::1]:51928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ72m-0003pS-CX for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Sep 2021 07:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ70x-0001Zl-MS for emacs-devel@gnu.org; Tue, 14 Sep 2021 07:54:16 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ70w-0000MC-33; Tue, 14 Sep 2021 07:54:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gE6EMBMne7663bInYhzU7PpmB9aMY/rAZ625X0E5mhk=; b=RNm4m2QW+gTTDlvsTnf390Zlfc mIeCQunvN64n4a7t10oIQC5hEke0+Krd2xTt53s01icK/Ey4ox5RXoOirV5CYS/t82DcT5HsE3VuV ga4/hK/jnBZfo68Ze4aiBx4T3QbUCvVdNYnl7QEdOeAUcknldwgRhQ0EkG2qgxg65UAw=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ70j-0006TH-SD; Tue, 14 Sep 2021 13:54:04 +0200 In-Reply-To: <83fsu7crbo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Sep 2021 14:46:51 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274692 Archived-At: Eli Zaretskii writes: >> So the problem seems to be that a `revert-buffer' doesn't keep overlays >> where they were, I guess? (Or remove the overlays, at least.) > > Are they removed, or do they move/evaporate because their markers > move? These overlays are zero-length, so they don't evaporate. But... perhaps they shouldn't be, and be marked with `evaporate'? That should make them go away in this case, at least. (I haven't really worked much with fringe markers before...) >> Do we have some machinery to handle overlays like this, or conventions >> about what to do with overlays when doing a `revert-buffer' actions? > > AFAIK, we already try to preserve the buffer markers, if possible. > And revert-buffer-with-fine-grain tries harder. So if the issue is > that the overlays' markers moved, we already try. But perhaps this doesn't work with zero-length overlays? (Those are handled specially in many circumstances.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no