From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: tab-bar-switch-to-tab removes custom tab data? Date: Mon, 20 Sep 2021 09:45:22 +0300 Organization: LINKOV.NET Message-ID: <871r5jpxed.fsf@mail.linkov.net> References: <8735q089zg.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 09:12:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDTy-00012P-5I for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 09:12:54 +0200 Original-Received: from localhost ([::1]:33278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDTw-0000cf-82 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 03:12:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDRt-0007Aq-Ka for emacs-devel@gnu.org; Mon, 20 Sep 2021 03:10:48 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:37639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDRp-00045f-Vd for emacs-devel@gnu.org; Mon, 20 Sep 2021 03:10:45 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5ED4424000B; Mon, 20 Sep 2021 07:10:35 +0000 (UTC) In-Reply-To: <8735q089zg.fsf@alphapapa.net> (Adam Porter's message of "Sun, 19 Sep 2021 17:40:51 -0500") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275111 Archived-At: > I'm not sure if this is intended, or if what I'm doing is allowed, but I > noticed that after I add an association to the current tab and then use > tab-switch twice, to change tab and then change back, the association I > added is gone. So you want to add more metadata to a tab? Once in the past I proposed such a feature, but no one needed it :) Now this could be added. > Here's the function I'm using to add the association: > > (defun burly-tab--windows-set-after-advice (&rest _ignore) > "Set current tab's `burly-bookmark-name' to BOOKMARK-NAME. > To be used as advice to `burly--windows-set'." > (tab-rename burly-opened-bookmark-name) > (let ((current-tab (tab-bar--current-tab-find))) > (setf (alist-get 'burly-bookmark-name (cdr current-tab)) > burly-opened-bookmark-name))) > > After that function is run, this: > > (tab-bar--current-tab-find) > > Evaluates to: > > (current-tab > (burly-bookmark-name . > #("Burly: Burly.el" 0 15 > (face nil))) > (name . > #("Burly: Burly.el" 0 15 > (face nil))) > (explicit-name . t)) > > Then after switching tabs and back, it evaluates to: > > (current-tab > (name . > #("Burly: Burly.el" 0 15 > (face nil))) > (explicit-name . t)) > > I assumed that, since the tab is an alist, I could add my own data to > it, but maybe this is not intended. If not, could it become so? :) I > could work around it by using the tab's name, but that would be less > flexible and robust. I'd also like to store other data to tabs in the > future, and that wouldn't work as well with relying on the tab name. I completely agree, this should be supported asap.