From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: pixel-point-and-height-at-unseen-line Date: Sat, 27 Nov 2021 14:57:06 +0800 Message-ID: <871r32cchp.fsf@yahoo.com> References: <83h7by146u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18210"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 07:58:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqrew-0004W4-5b for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 07:58:06 +0100 Original-Received: from localhost ([::1]:53616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqreu-00076E-9T for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 01:58:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqreH-0006Ri-Vb for emacs-devel@gnu.org; Sat, 27 Nov 2021 01:57:25 -0500 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:39819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqreG-00075M-DY for emacs-devel@gnu.org; Sat, 27 Nov 2021 01:57:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637996238; bh=WZvpKOCa1AIDn3UIy7U7wTp5XW63aK/X1A8LzMG6ULg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=KXRn0J1+U3dEbqDG5xlUY/BiKpjTioJk7uK0lZyCSf2m8xtG0GXxaiREQZaS7jVk9/+TO8LHu1cEpoDCJLMotilE5ESjDUTbf2Nb5nGGf2VJGPGRGd+cPDLTmX8A7MSI7UTL5pEIvNT0DsU50iJ+aKWTXnJ0VDYnfCTbbsHBgKRYM78lGMJEQ3bs+/Zfz3islr9dBSJe46GdZynDw+v6AO+uAn3uYBIlCXbLqPr2DTJsRWHBma7OVYmI1jwYUfV82AFy0bWY6iefZJ5gLIyvQ8QFFUa5QiNpCaf+DsW4DFH2kmuh3Nsqp3mPCYXwWgkvvwUEpdEqJmnJKjaALPjnSQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637996238; bh=BRStZbFadipiTzT+XV4ba0OKtsbp2NcuvrUxWkRqjc/=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=j9JnN52aHif5nZsDqZXPzcxh7E7KaNU9aELXJCoi7X7F/AldkrAnsEv4cEjvIGBFJvxNVTp/R/hNpEt1r7MdgCaFis0w2yZpNisR4ypGc/eMtVYYL6urLS6aAGXtUzkxeVOY3BSZ82dOcD2BMZ4Hi6xkOvA4d1Ahh248UJhTaS214zAIV1dTW5QMxhON6qpkFsJMxSlQ0V/UM0HhFSZC5pbKqAq+tHX+GfReATC5bZCt+rabhMurk6Xs3NQCF9wtYAOAV7wMbUGkQrQhjofwAmvxq97P/dhIj5WgHnYyPIAP208Je1m8IQqlYjmZX3aTExSkeeDSgcNlBEBvc8idqg== X-YMail-OSG: fAwUs4oVM1l0bi7SAwhhmrOwSlfuWuWP.YSRAW_HpwIuXGr0Y9noFSenGdFB.gs JbYbXRtsnehG1RYFlG9z2RxI0xFVQeT.WF59jb6aCpKIfQ2hmJ.6cVUEBePUBjl4YbBaIPI__yJD OuKPYVr6euJgDVQZK7BXjcVRWZHNbfvSUnaTcIn69l5TZqSJPItjSWjSsYm4XOIRy5sYONNDQyb2 DfZr7io8.QgRLtbfCzcNyBv7WD6EP6yte7WTsrzb2_JIXtnH4deY4tz.btOX2yDnzt59FBUDY26G ceebFTOf9qhA5ZfA3JhZNZ3yObD07XTa8m8eX___dmWrEmg9M1earTLku4e_Dct7xX8u.27czJ5A NL2qML3HUpacZ9gMMrWpfxcY20GfxzHFXfGrLNGvgMiug7hAR0p28FLCXcr5VvtVgCTFI84z2Yap fMWcLfniz7CItHIXAy_SS3tIc7pQIG_wYw6DOewenjgKwT3uEbHeAcLZK2acMbFU.pmHA2PjLP3q eLrY8qR0BPJ8gWJYrSH9SiMLsTuIE9Fv_hArXr.d_KbElgGrSV.Pm9NiECoEuCMqvRJJTT8kTYu8 Tp0MMfsravDcQ4HQlOT2lxp9NqYy5p3g5FBA68mZr6IGp8cNVEbZDohh2TG4p6I1uIhjWui385qd FzZzDWoRFMUcK2s3EC4Zg4mTPnukJLi1RYHPd3nPzF2riQGmWdbocryDkvGQLB3.aIrfdYGtdxTY TNqRUYlb.t4jSzEkMUe.ibMAI0_XXq9DIjKSHGSGYX8SAojAlB4yMeuDCk7dH0WG0pObye2yP6VM tZvK5F1.pDLCb3T5YWcwspIYTiRTOCNE0S4oWY7bYb X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sat, 27 Nov 2021 06:57:18 +0000 Original-Received: by kubenode509.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 816e2d7e22e5adbbdf55340a608da179; Sat, 27 Nov 2021 06:57:11 +0000 (UTC) In-Reply-To: <83h7by146u.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Nov 2021 08:51:53 +0200") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.204; envelope-from=luangruo@yahoo.com; helo=sonic310-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280296 Archived-At: Eli Zaretskii writes: > This function has several problems that IMO would be good to clean up: > > . It's unnecessarily restricted to a very special use case: a single > screen line above the one where window-start is. It could be much > more useful (and be moved to subr.el or simple.el) if it could at > least accept an argument to control on which line or position to > report. > > . It changes important state variables without protecting itself from > errors and non-local exits, so a C-g at an opportune time will > disrupt the buffer/window state. > > . It calls vertical-motion without checking its return value, which > could tell you whether it actually moved at all, and where. (One > bonus of checking the return value is that you could perhaps drop > the bobp test there.) vertical-motion can do some surprising > things around overlays and display properties, especially ones that > include newlines in their strings. > > Thanks. I'll look into that. I did not write that function, I only modified it (and moved it) so I could reuse the code there in for precision pixel scrolling. Thanks.