unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 22ae842b34: Add new hooks when enabling and disabling themes
       [not found] ` <20220521125702.D42A9C009A8@vcs2.savannah.gnu.org>
@ 2022-05-21 13:25   ` Po Lu
  2022-05-21 13:39     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Po Lu @ 2022-05-21 13:25 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +---
> +*** New hooks 'enable-theme-hook' and 'disable-theme-hook'.
> +These are run after enabling and disabling a theme, respectively.
> +
> +---
> +*** Themes can now be made obsolete.
> +Using 'make-obsolete' on a theme is now supported.  This will make
> +'load-theme' issue a warning when loading the theme.

> +  "Atypical hook run after a theme has been enabled.

We name abnormal hooks `foo-functions', so shouldn't this be
`enable-theme-functions' and `disable-theme-functions'?



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 22ae842b34: Add new hooks when enabling and disabling themes
  2022-05-21 13:25   ` master 22ae842b34: Add new hooks when enabling and disabling themes Po Lu
@ 2022-05-21 13:39     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-21 13:39 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

Po Lu <luangruo@yahoo.com> writes:

> We name abnormal hooks `foo-functions', so shouldn't this be
> `enable-theme-functions' and `disable-theme-functions'?

Yes.  See the bug thread.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-21 13:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <165313782247.24362.11835798888541393103@vcs2.savannah.gnu.org>
     [not found] ` <20220521125702.D42A9C009A8@vcs2.savannah.gnu.org>
2022-05-21 13:25   ` master 22ae842b34: Add new hooks when enabling and disabling themes Po Lu
2022-05-21 13:39     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).