From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Fri, 27 May 2022 15:39:04 +0200 Message-ID: <871qwf14ef.fsf@elite.giraud> References: <877d6b88pz.fsf@elite.giraud> <875ylv6j58.fsf@elite.giraud> <87o7zngcgf.fsf@gnus.org> <87k0a93g4z.fsf@elite.giraud> <87y1yp1vnw.fsf@elite.giraud> <877d69lyt2.fsf@red-bean.com> <87ilpsd0hv.fsf@gnus.org> <87tu9c1c0k.fsf@elite.giraud> <87leuo12fh.fsf@elite.giraud> <87zgj38ds1.fsf@gnus.org> <875ylr15nm.fsf@elite.giraud> <8735gv6rim.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Stefan Monnier , Karl Fogel , Drew Adams , emacs-devel To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 27 15:39:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuaBz-0005b8-0h for ged-emacs-devel@m.gmane-mx.org; Fri, 27 May 2022 15:39:51 +0200 Original-Received: from localhost ([::1]:36828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuaBx-0003Ih-Hi for ged-emacs-devel@m.gmane-mx.org; Fri, 27 May 2022 09:39:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuaBM-0002cY-QP for emacs-devel@gnu.org; Fri, 27 May 2022 09:39:13 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:48584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuaBL-0005Iy-0f for emacs-devel@gnu.org; Fri, 27 May 2022 09:39:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=7QNjBfEPoLkhUMUO mjwxo3xddgkDose5Zt5vPVQAVpk=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=1bKfghu934j/55CvwDDHfhvBP91z0E8tqzG/jM bAbkwfbb/NNQ9rvkDD65kFjUokxFluqVNPshfXHVBhItonirHkde0aZsh//O+g9vvf/W6R wJu7zc/3NlIp3+6b0jokeJ3TFX0oti0ELtzJDI+o25QAEq7e+OltuI4LRWc/rn1lK6BsF/ V6EBR0pM7nZ8Wg8rfMQPP9wDCBNH0+RWK5X1529RuF0tgKs7SXRu/2kYunxzb0UD1aziAL 7ASiVBbnMKp5QVQby7A/4M07I93QlOY4Cd8FMhX0PRGWF96P6KWlZ9Heiwi0e+AVoqABTy DG/FkGjDdSu66ZC8z3AlAHag== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 804b44d2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 27 May 2022 15:39:07 +0200 (CEST) In-Reply-To: <8735gv6rim.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 27 May 2022 15:20:49 +0200") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290314 Archived-At: Lars Ingebrigtsen writes: > Manuel Giraud writes: > >> With the patch a call to (bookmark-make-record) will have an up to date >> last-modified field so it cannot be equal to a static bookmark record. >> For the same reason, two successive calls won't be equal. Should I try >> to fix those tests or fix my code? > > Sounds like fixing the tests is the right thing. Sorry, I've just checked and I could leave 'bookmark-make-record' untouched and slap a last-modified on the record in 'bookmark-set-internal'. WDYT? -- Manuel Giraud